Conversation
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "upcoming": [ | |||
There was a problem hiding this comment.
Would it make sense to just pull this at build time from Discord?
There was a problem hiding this comment.
We certainly could. It would likely mean we need a Discord app + API key created for it. Did we already have that somewhere? And if it is can you add it as secret env vars in the GitHub Action secrets settings for this repo?
There was a problem hiding this comment.
Yeah we have an action now that does the thing
https://github.com/austinmesh/www/blob/main/.github/workflows/update-discord-event.yml
https://github.com/austinmesh/www/blob/main/scripts/update-discord-event.sh
| threshold: 0.1 | ||
| }; | ||
|
|
||
| const loadBackground = (container) => { |
There was a problem hiding this comment.
It looks like some lazy loader thingy. It is something already on the site at https://github.com/austinmesh/www/blob/main/index.html#L140C1-L172C14 that was just copied over. But if you don't remember we could probably get rid of it. I don't know that there is any benefit to lazy loading one image on the homepage...
There was a problem hiding this comment.
huh, I even search the repo for it but my find didn't come up with any results so I assumed it was new.
I vaguely remember it now. It's just for performance. There are some other lazy images around the site, so it'd need to be loaded there, too.
| } No newline at end of file | ||
| } | ||
|
|
||
| /* Social media icon colors */ |
There was a problem hiding this comment.
Is this just some AI code, or did you specifically want to change this stuff?
There was a problem hiding this comment.
I specifically did change the icons to all be from the same package so that they had a more consistent look (they are from https://simpleicons.org/). If we want the original ones do you know where they came from so we can try to consistently style them?
There was a problem hiding this comment.
I don't recall, probably just off of Google.
I was mainly wondering because of all of the !important tags which are usually a red flag for me. I think this is fine for now
There was a problem hiding this comment.
I'll do a pass at the !important ones again. Some of them were required so they are ignored when the dark theme gets used and it looks correct on the light version.
There was a problem hiding this comment.
Let's just leave it as is. Or let them be grayscale if that's simpler? No big deal
2 participants
Website refactor in Eleventy. Supersedes number #17.