Open
Conversation
This reverts commit 240d59c.
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Author
|
yes it's still relevant, I am waiting a review from an employee of Auth0 |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Author
|
are you even reading pull requests? |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Author
|
I don't use this addon anymore as it seems that you don't care about it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✏️ Changes
following the last recommendation about automatic linking identities. As recommended, we wanted to use this extension. As we use a custom domain and the rest of the Auth0 configuration is managed through Terraform, we want to ease future migration. We think that rules configs are exactly there to fix this problem, as with rules configs, we don't need to change anymore the rule itself.
The rule can now be always the same and configured at run time thanks to rules configs.
🔗 References
remove secret from source code #77
allow to edit the custom domain without changing the rule #59
🎯 Testing
as Webtask seems to be deprecated, it's difficult to test.
✅🚫 This change has been tested in a Webtask
✅🚫 This change has unit test coverage
✅🚫 This change has integration test coverage
✅🚫 This change has been tested for performance
🚀 Deployment
the deployment of this change can be done at any time. for the last time user with custom domain will need to do a manipulation, they will need to set the rules config
customDomain. at that time, we can also apply the following change in the documentation.✅ This can be deployed any time
🎡 Rollout
In order to verify that the deployment was successful we will …
🔥 Rollback
We will rollback if …
📄 Procedure
🖥 Appliance
Note to reviewers: ensure that this change is compatible with the Appliance.