Conversation
Widcket
commented
Mar 11, 2025
|
|
||
| } | ||
|
|
||
| context("api credentials") { |
Contributor
Author
There was a problem hiding this comment.
These are the tests for the async/await wrapper.
Widcket
commented
Mar 11, 2025
|
|
||
| } | ||
|
|
||
| context("api credentials") { |
Contributor
Author
There was a problem hiding this comment.
These are the tests for the Combine wrapper. Combine is Apple's framework for functional reactive programming.
pmathew92
reviewed
Mar 12, 2025
| parameters: [String: Any], | ||
| headers: [String: String], | ||
| forceRenewal: Bool = false, | ||
| forceRenewal: Bool, |
Contributor
There was a problem hiding this comment.
Any particular reason to remove the default value from forceRenewal parameter ?
Contributor
Author
There was a problem hiding this comment.
So it's explicit at the call site.
NandanPrabhu
previously approved these changes
Apr 21, 2025
pmathew92
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR moves the Credentials Manager from a single credentials model to a multiple credentials one, supporting:
To this end, two new public methods were added to the Credentials Manager:
The Authentication API client's
renew(withRefreshToken:scope:)method also gained a newaudienceargument —that defaults tonil— allowing the exchange of a refresh token for API-specific credentials.🎯 Testing
A complete test suite is included.