Skip to content

SDK-5915 address git hub issue 872#947

Merged
NandanPrabhu merged 9 commits intomasterfrom
feature/SDK-5915
May 12, 2025
Merged

SDK-5915 address git hub issue 872#947
NandanPrabhu merged 9 commits intomasterfrom
feature/SDK-5915

Conversation

@NandanPrabhu
Copy link
Contributor

@NandanPrabhu NandanPrabhu commented May 2, 2025

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Addresses #872
Added JWTDecode and SimpleKeychain as submodule dependency to Auth0 framework
Adding Auth0 framework will ensure JWTDecode and SimpleKeychain comes with it as nested dependency

📎 References

🎯 Testing

@NandanPrabhu NandanPrabhu requested a review from a team as a code owner May 2, 2025 06:51
@NandanPrabhu NandanPrabhu changed the title added JWTDecode and SimpleKeychain as submodules in Auth0 SDK-5915 address git hub issue 872 May 6, 2025
@Widcket
Copy link
Contributor

Widcket commented May 8, 2025

@NandanPrabhu have you tested with a separate Carthage app that it works correctly? Also with a Cocoapods app?

Please also update the instructions in the CONTRIBUTING.md file because now the last step is no longer necessary: https://github.com/auth0/Auth0.swift/blob/master/CONTRIBUTING.md?plain=1#L13

isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
D41DED152DCA07D100F5B1A4 /* CwlPreconditionTesting in Frameworks */,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not necessary for tvOS.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CwlPosixPreconditionTesting is used instead.

@NandanPrabhu NandanPrabhu merged commit a484f3a into master May 12, 2025
12 of 13 checks passed
@NandanPrabhu NandanPrabhu deleted the feature/SDK-5915 branch May 12, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants