Upgrades Xcode version to 16 in CI#275
Merged
NandanPrabhu merged 8 commits intomasterfrom Apr 25, 2025
Merged
Conversation
Widcket
reviewed
Apr 23, 2025
Package.swift
Outdated
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version:5.9 | |||
| // swift-tools-version:6.0.2 | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // swift-tools-version:6.0.2 | |
| // swift-tools-version:6.0 |
Any particular reason for specifying 6.0.2 here and in the Podspec?
Widcket
reviewed
Apr 23, 2025
JWTDecode.podspec
Outdated
|
|
||
| s.source_files = 'JWTDecode/*.swift' | ||
| s.swift_versions = ['5.9'] | ||
| s.swift_versions = ['6.0.2', '6.0.3', '6.1'] |
Contributor
There was a problem hiding this comment.
Suggested change
| s.swift_versions = ['6.0.2', '6.0.3', '6.1'] | |
| s.swift_versions = ['6.0', '6.1'] |
Any particular reason for specifying 6.0.2 and 6.0.3 here?
Widcket
reviewed
Apr 23, 2025
JWTDecodeTests/JWTDecodeSpec.swift
Outdated
| #if compiler(>=6.0) | ||
| extension JWTDecodeError: @retroactive Equatable {} | ||
| #else | ||
| extension JWTDecodeError: Equatable {} |
Contributor
There was a problem hiding this comment.
In this case, the @retroactive declaration should be left in place, because it will always be built with the Swift 6.0 compiler (or later).
Widcket
reviewed
Apr 25, 2025
| path: "JWTDecodeTests", | ||
| exclude: ["Info.plist"]) | ||
| exclude: ["Info.plist"], | ||
| swiftSettings: [.swiftLanguageMode(.v5)]) |
Widcket
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Changes
Upgrades
📎 References
🎯 Testing