Skip to content

Custom Token Exchange #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tusharpandey13 merged 5 commits into from
Mar 6, 2025
Merged

Custom Token Exchange #1344

tusharpandey13 merged 5 commits into from
Mar 6, 2025

Conversation

@tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Feb 25, 2025 •
edited
Loading

Changes

Authentication api

  • Added exchangeToken method in Auth0Client
  • Added file TokenExchange.ts
  • Added unit tests for same

References

Custom Token Exchange Beta

Test results

=============================== Coverage summary ===============================
Statements   : 100% ( 3751/3751 )
Branches     : 100% ( 596/596 )
Functions    : 100% ( 131/131 )
Lines        : 100% ( 3751/3751 )
================================================================================

Test Suites: 26 passed, 26 total
Tests:       481 passed, 481 total
Snapshots:   0 total
Time:        13.449 s

Checklist

@tusharpandey13 tusharpandey13 requested a review from a team as a code owner February 25, 2025 08:28
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 25, 2025
View reviewed changes
@tusharpandey13 tusharpandey13 changed the title feature/cte Custom Token Exchange Feb 25, 2025
@gyaneshgouraw-okta
Copy link
Contributor

gyaneshgouraw-okta commented Mar 3, 2025 •
edited
Loading

@tusharpandey13 we should also updated Examples.md as part of this feature

@tusharpandey13 tusharpandey13 merged commit 8b1609d into main Mar 6, 2025
14 checks passed
@tusharpandey13 tusharpandey13 deleted the feature/cte branch March 6, 2025 10:30
frederikprijck
frederikprijck reviewed Mar 27, 2025
View reviewed changes
src/Auth0Client.ts
subject_token: options.subject_token,
subject_token_type: options.subject_token_type,
scope: getUniqueScopes(options.scope, this.scope),
audience: this.options.authorizationParams.audience
Copy link
Member

@frederikprijck frederikprijck Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options contains audience, but it is never used.

This should be:

Suggested change
audience: this.options.authorizationParams.audience
audience: options.audience || this.options.authorizationParams.audience

Copy link
Member

@frederikprijck frederikprijck Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, options can contain any custom property, but this is never passed through.

@tusharpandey13 tusharpandey13 mentioned this pull request May 27, 2025
Merged
tusharpandey13 added a commit that referenced this pull request May 28, 2025
@tusharpandey13
Release v2.2.0 (#1357)
b4515f5 
**Added**
- Custom Token Exchange
[\#1344](#1344)
([tusharpandey13](https://github.com/tusharpandey13))
- Add RL-Secure workflow for scanning build artifacts
[\#1281](#1281)
([developerkunal](https://github.com/developerkunal))

**Changed**
- build(deps-dev): Bump ejs from 3.1.8 to 3.1.10
[\#1267](#1267)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps-dev): Bump braces from 3.0.2 to 3.0.3
[\#1278](#1278)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps-dev): Bump axios from 1.6.2 to 1.7.7
[\#1298](#1298)
([dependabot[bot]](https://github.com/apps/dependabot))
- Changed the trigger from pull_request_target to pull_request for
better security
[\#1297](#1297)
([gyaneshgouraw-okta](https://github.com/gyaneshgouraw-okta))
- Update codeowner file with new GitHub team name
[\#1288](#1288)
([stevenwong-okta](https://github.com/stevenwong-okta))
- build(deps-dev): Bump typedoc from 0.25.4 to 0.25.9
[\#1250](#1250)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps): Bump codecov/codecov-action from 3.1.4 to 3.1.5
[\#1238](#1238)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps): Bump actions/cache from 3 to 4
[\#1236](#1236)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps-dev): Bump eslint from 8.55.0 to 8.56.0
[\#1223](#1223)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps): Bump github/codeql-action from 2 to 3
[\#1221](#1221)
([dependabot[bot]](https://github.com/apps/dependabot))
- Update automated release process to latest version
[\#1222](#1222)
([frederikprijck](https://github.com/frederikprijck))
- build(deps-dev): Bump browserstack-cypress-cli from 1.27.0 to 1.28.0
[\#1220](#1220)
([dependabot[bot]](https://github.com/apps/dependabot))
- Use outputs for capturing release-notes
[\#1218](#1218)
([frederikprijck](https://github.com/frederikprijck))
- build(deps-dev): Bump rollup-plugin-visualizer from 5.10.0 to 5.11.0
[\#1215](#1215)
([dependabot[bot]](https://github.com/apps/dependabot))

**Fixed**
- chore: migrate jenkins job to k8s agent pipeline
[\#1251](#1251)
([xmanwms95](https://github.com/xmanwms95))
- Ensure tag-exists action works as intended
[\#1217](#1217)
([frederikprijck](https://github.com/frederikprijck))
- Align release process by supporting npm provenance and tag and
release-directory
[\#1216](#1216)
([frederikprijck](https://github.com/frederikprijck))
- Bring back pull_request trigger to release process
[\#1214](#1214)
([frederikprijck](https://github.com/frederikprijck))
@tusharpandey13 tusharpandey13 mentioned this pull request May 28, 2025
Merged
tusharpandey13 added a commit that referenced this pull request May 28, 2025
@tusharpandey13
Release v2.2.0 (#1362)
85a6ded 
**Added**
- Custom Token Exchange
[\#1344](#1344)
([tusharpandey13](https://github.com/tusharpandey13))
- Add RL-Secure workflow for scanning build artifacts
[\#1281](#1281)
([developerkunal](https://github.com/developerkunal))

**Changed**
- build(deps): Bump codecov/codecov-action from 3.1.4 to 3.1.5
[\#1238](#1238)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps-dev): Bump ejs from 3.1.8 to 3.1.10
[\#1267](#1267)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps-dev): Bump braces from 3.0.2 to 3.0.3
[\#1278](#1278)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps-dev): Bump axios from 1.6.2 to 1.7.7
[\#1298](#1298)
([dependabot[bot]](https://github.com/apps/dependabot))
- Changed the trigger from pull_request_target to pull_request for
better security
[\#1297](#1297)
([gyaneshgouraw-okta](https://github.com/gyaneshgouraw-okta))
- Update codeowner file with new GitHub team name
[\#1288](#1288)
([stevenwong-okta](https://github.com/stevenwong-okta))
- chore: migrate jenkins job to k8s agent pipeline
[\#1251](#1251)
([xmanwms95](https://github.com/xmanwms95))
- build(deps-dev): Bump typedoc from 0.25.4 to 0.25.9
[\#1250](#1250)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps): Bump actions/cache from 3 to 4
[\#1236](#1236)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps-dev): Bump eslint from 8.55.0 to 8.56.0
[\#1223](#1223)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps): Bump github/codeql-action from 2 to 3
[\#1221](#1221)
([dependabot[bot]](https://github.com/apps/dependabot))
- Update automated release process to latest version
[\#1222](#1222)
([frederikprijck](https://github.com/frederikprijck))
- build(deps-dev): Bump browserstack-cypress-cli from 1.27.0 to 1.28.0
[\#1220](#1220)
([dependabot[bot]](https://github.com/apps/dependabot))
- build(deps-dev): Bump rollup-plugin-visualizer from 5.10.0 to 5.11.0
[\#1215](#1215)
([dependabot[bot]](https://github.com/apps/dependabot))

**Fixed**
- Fix release workflows
[\#1361](#1361)
([tusharpandey13](https://github.com/tusharpandey13))
- Use outputs for capturing release-notes
[\#1218](#1218)
([frederikprijck](https://github.com/frederikprijck))
- Ensure tag-exists action works as intended
[\#1217](#1217)
([frederikprijck](https://github.com/frederikprijck))
- Align release process by supporting npm provenance and tag and
release-directory
[\#1216](#1216)
([frederikprijck](https://github.com/frederikprijck))
- Bring back pull_request trigger to release process
[\#1214](#1214)
([frederikprijck](https://github.com/frederikprijck))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frederikprijck frederikprijck frederikprijck left review comments

@gyaneshgouraw-okta gyaneshgouraw-okta gyaneshgouraw-okta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tusharpandey13 @gyaneshgouraw-okta @frederikprijck