fix: handle undefined value when finding MRRT refresh token #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `useMrrt` is enabled and you call `getTokenSilently` for an audience that isn't in the cache, the library will use a refresh token from a different entry in the cache to fetch the new token. But, if you called `getTokenSilently` for an audience who's key is in the cache, but who's value returns `undefined`, then it would not do this, it would just return a MissingRefreshTokenError. To fix this, the code has been modified to check the value retrieved from the cache, rather than just checking whether the key exists. The cache returning undefined for an existing key is valid behavior and could even be likely if using a custom cache implementation. Even with the standard cache though, it could still happen if the cache entry is deleted between the keys being fetched and the value being fetched. Or if the cache value has been corrupted somehow, and doesn't parse to valid JSON.
mogzol
force-pushed
the
fix-mrrt-cache-undefined
branch
from
1dbb0bd to
a14236d
Compare
yogeshchoudhary147
approved these changes
Jan 15, 2026
Contributor
yogeshchoudhary147
left a comment
yogeshchoudhary147
left a comment
There was a problem hiding this comment.
Verified this fix works correctly. Tested the scenario where a cache entry
exists but returns undefined (corrupted JSON). The library now properly
falls back to using refresh tokens from other cache entries instead of
throwing MissingRefreshTokenError.
✅ Test passed with the fix applied.
Merged
yogeshchoudhary147
added a commit
that referenced
this pull request
Jan 16, 2026
**Fixed** - fix: add two-tier locking to prevent iframe race conditions causing "Invalid state" errors [\#1505](#1505) ([yogeshchoudhary147](https://github.com/yogeshchoudhary147)) - fix: handle undefined value when finding MRRT refresh token [\#1508](#1508) ([mogzol](https://github.com/mogzol)) - fix: update refresh token in all cache entries on rotation [\#1503](#1503) ([gyaneshgouraw-okta](https://github.com/gyaneshgouraw-okta))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When
useMrrtis enabled and the library is retrieving a token from the cache, it will now handle the case where the requested audience has a key in the cache, but the value isundefined. Previously this would cause an issue where the library would fail to try using the refresh token from other cache entries. See #1507.References
Fixes #1507.
Testing
Checklist