-
Notifications
You must be signed in to change notification settings - Fork 33
AIDX-319 Add python counterparts to MCP get started pages #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
auth4genai/snippets/mcp/get-started/call-your-apis/exchange-access-token-python.mdx
Outdated
Show resolved
Hide resolved
auth4genai/snippets/mcp/get-started/call-your-apis/exchange-access-token-python.mdx
Outdated
Show resolved
Hide resolved
auth4genai/snippets/mcp/get-started/call-your-apis/exchange-access-token-js.mdx
Outdated
Show resolved
Hide resolved
pmalouin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments for the python quickstarts. I have not checked the JS quickstarts as a whole, but some of my feedback applies to it too.
| @@ -0,0 +1,31 @@ | |||
| From the root of your sample app directory, run the following command to create a new `.env` file populated with all the required environment variables: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we suggest to copy the .env.example file instead? There are some extra env variables set there that are missing in this block (which we can leave alone, but not too sure if we can omit them).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the command we have to create .env file is probably better here, because it populates all the required fields rather than copying and filling out the fields manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough, this particular one might not apply. But I see some other places in auth4genai/snippets/mcp/get-started/server-authorization.mdx where we instruct the developer to create a new .env file and manually add some variables to it. I suspect those ones should be improved, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, will update that page as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Description
Adds python counterparts to MCP get started pages:
Authorization for Your MCP ServerandCall Your API on a user's behalfpages.References
Testing
Tested locally:
Checklist