Skip to content

fix: add Vale linting#442

Merged
darrickyong merged 1 commit intomainfrom
DM-4
Jan 14, 2026
Merged

fix: add Vale linting#442
darrickyong merged 1 commit intomainfrom
DM-4

Conversation

@darrickyong
Copy link
Contributor

@darrickyong darrickyong commented Dec 22, 2025

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.

If the UI is being changed, please provide screenshots.

This PR adds vale as a Github Action and initial vale config.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@darrickyong darrickyong self-assigned this Dec 22, 2025
@darrickyong darrickyong marked this pull request as draft December 22, 2025 19:31
@darrickyong darrickyong force-pushed the DM-4 branch 2 times, most recently from e56749c to 267c7c6 Compare January 7, 2026 19:16
@darrickyong darrickyong changed the title fix: [DM-4] update custom dictionary fix: [DM-4] add Vale linting Jan 7, 2026
@darrickyong darrickyong marked this pull request as ready for review January 7, 2026 20:16
Copy link
Contributor

@mikemimik mikemimik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 The output of the vale action is a little different than I expected. I thought that it would be similar to the terminal output you showed me @darrickyong when implementing this. My expectation was that the action would fail, not pass, and I'm curious why that is.

@darrickyong darrickyong requested a review from mikemimik January 8, 2026 16:31
@mikemimik mikemimik changed the title fix: [DM-4] add Vale linting fix: add Vale linting [DM-4] Jan 8, 2026
@hazel-nut hazel-nut self-assigned this Jan 8, 2026
Copy link
Contributor

@hazel-nut hazel-nut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move the vale config back to the a4aa directory while it's only applying to a4aa docs. the github action is handy! have you looked into using reviewdog to leave inline PR comments?

@github-actions
Copy link

@darrickyong darrickyong merged commit fb69710 into main Jan 14, 2026
2 checks passed
@darrickyong darrickyong deleted the DM-4 branch January 14, 2026 17:02
daniloasis-auth0 pushed a commit to daniloasis-auth0/docs-v2 that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants