chore(deps-dev): Bump node-forge from 1.3.1 to 1.3.3

[dependabot]

Bumps node-forge from 1.3.1 to 1.3.3.

Changelog

Sourced from node-forge's changelog.

1.3.2 - 2025-11-25

Security

• HIGH: ASN.1 Validator Desynchronization
  • An Interpretation Conflict (CWE-436) vulnerability in node-forge versions 1.3.1 and below enables remote, unauthenticated attackers to craft ASN.1 structures to desynchronize schema validations, yielding a semantic divergence that may bypass downstream cryptographic verifications and security decisions.
  • Reported by Hunter Wodzenski.
  • CVE ID: CVE-2025-12816
  • GHSA ID: GHSA-5gfm-wpxj-wjgq
• HIGH: ASN.1 Unbounded Recursion
  • An Uncontrolled Recursion (CWE-674) vulnerability in node-forge versions 1.3.1 and below enables remote, unauthenticated attackers to craft deep ASN.1 structures that trigger unbounded recursive parsing. This leads to a Denial-of-Service (DoS) via stack exhaustion when parsing untrusted DER inputs.
  • Reported by Hunter Wodzenski.
  • CVE ID: CVE-2025-66031
  • GHSA ID: GHSA-554w-wpv2-vw27
• MODERATE: ASN.1 OID Integer Truncation
  • An Integer Overflow (CWE-190) vulnerability in node-forge versions 1.3.1 and below enables remote, unauthenticated attackers to craft ASN.1 structures containing OIDs with oversized arcs. These arcs may be decoded as smaller, trusted OIDs due to 32-bit bitwise truncation, enabling the bypass of downstream OID-based security decisions.
  • Reported by Hunter Wodzenski.
  • CVE ID: CVE-2025-66030
  • GHSA ID: GHSA-65ch-62r8-g69g

Fixed

• [asn1] Fix for vulnerability identified by CVE-2025-12816 PKCS#12 MAC verification bypass due to missing macData enforcement and improper asn1.validate routine.
• [asn1] Add fromDer() max recursion depth check.
  • Add a asn1.maxDepth global configurable maximum depth of 256.
  • Add a asn1.fromDer() per-call maxDepth option.
  • NOTE: The default maximum is assumed to be higher than needed for valid data. If this assumption is false then this could be a breaking change. Please file an issue if there are use cases that need a higher maximum.
  • NOTE: The per-call maxDepth parameter has not been exposed up through all of the API stack due to the complexities involved. Please file an issue if there are use cases that require this instead of changing the default maximum.
• [asn1] Improve OID handling.
  • Error on parsed OID values larger than 2**32 - 1.
  • Error on DER OID values larger than 2**53 - 1 .

Commits

• 235ad3e Release 1.3.2.
• 2598244 Update changelog.
• 0032dd0 Fix typos.
• d75e08d Run new security test.
• a5ce91d Update changelog formatting.
• 4652de6 Cleanups.
• eb932d9 Fix typo.
• db6954b Fix style.
• afbf7d8 Align error message style.
• 6607445 Revert minor changes.
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  You can disable automated security fix PRs for this repo from the Security Alerts page.

[ankita10119]

@claude

[github-actions]

Claude finished @ankita10119's task —— View job

---

Review Progress

• Read PR diff and understand changes
• Read project context
• Perform code quality review
• Perform security review
• Perform performance review
• Provide final assessment

---

Overall Assessment

❌ This PR has a critical discrepancy: the title and description indicate an update to node-forge 1.3.2, but the actual change updates to 1.3.3. The version mismatch must be resolved and verified before merging to ensure the correct security patches are applied.

Review Summary

Critical Issue Identified:

• The PR metadata (title/description) states this updates node-forge from 1.3.1 to 1.3.2
• The actual package-lock.json change updates to version 1.3.3
• This discrepancy needs investigation to confirm whether 1.3.3 is intentional and includes all the required security fixes

Security Context:
This dependency update addresses three significant security vulnerabilities:

• HIGH: CVE-2025-12816 - ASN.1 Validator Desynchronization
• HIGH: CVE-2025-66031 - ASN.1 Unbounded Recursion (DoS)
• MODERATE: CVE-2025-66030 - ASN.1 OID Integer Truncation

Technical Assessment:

• node-forge is a transitive dev dependency (not directly declared in package.json)
• The change only modifies package-lock.json with version, resolved URL, and integrity hash updates
• A license field was added: (BSD-3-Clause OR GPL-2.0)
• No breaking changes expected as this is a patch/minor version update

Recommendations:

1. Verify that version 1.3.3 is the correct target version
2. If 1.3.3 is correct, update the PR title and description accordingly
3. Confirm 1.3.3 includes all mentioned CVE fixes
4. Run CI tests to ensure no regressions
5. Consider checking which parent dependency uses node-forge to understand the update chain

---

[ankita10119]

@dependabot Please update the PR metadata.
The title and description are outdated and no longer accurately describe the dependency upgrade.

Could you refresh both so they correctly summarize the package version change and any relevant release notes?

[dependabot]

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

[ankita10119]

@dependabot recreate

[ankita10119]

@dependabot The PR metadata is out of sync: the title/description reference 1.3.2, but the lock file upgrades to 1.3.3.

Please regenerate the PR title + description and validate whether v1.3.3 includes the CVE fixes noted in the PR body.