-
Notifications
You must be signed in to change notification settings - Fork 559
chore(deps): Bump js-yaml and css-loader #2696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9b229f4 to
f33de54
Compare
|
Claude finished @ankita10119's task —— View job Review Progress
Overall Assessment❌ This PR contains a critical breaking change that will cause build failures. The css-loader upgrade from v0.28.11 to v7.1.2 introduces breaking changes that are incompatible with the current codebase. Critical Issues1. css-loader v7 Breaking Change - Import SyntaxLocation: The current code uses: import css from '../css/index.styl';In css-loader v7, when import * as css from '../css/index.styl';Impact: Without fixing this, the build will fail or CSS will not load correctly. Resolution Options: Option A (Recommended for compatibility): Update {
test: /\.styl$/,
use: [
{
loader: 'css-loader',
options: {
esModule: false
}
},
'stylus-loader',
{
loader: 'stylus-loader',
options: {
paths: ['node_modules/bootstrap-stylus/stylus'],
preferPathResolver: 'webpack'
}
}
]
}Option B: Update the import statement in Security Review✅ js-yaml v4.1.1 security update: This PR correctly addresses CVE-2025-XXXXX (prototype pollution vulnerability in the YAML merge operator). This security fix should be applied. Additional Concerns
Recommendation
|
f33de54 to
8d54b26
Compare
Bumps [js-yaml](https://github.com/nodeca/js-yaml) to 4.1.1 and updates ancestor dependencies [js-yaml](https://github.com/nodeca/js-yaml) and [css-loader](https://github.com/webpack-contrib/css-loader). These dependencies need to be updated together. Updates `js-yaml` from 4.1.0 to 4.1.1 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) Updates `js-yaml` from 3.14.1 to 3.14.2 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) Updates `css-loader` from 0.28.11 to 7.1.2 - [Release notes](https://github.com/webpack-contrib/css-loader/releases) - [Changelog](https://github.com/webpack/css-loader/blob/main/CHANGELOG.md) - [Commits](webpack/css-loader@v0.28.11...v7.1.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: indirect - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect - dependency-name: css-loader dependency-version: 7.1.2 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
8d54b26 to
c05d12f
Compare
ankita10119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified changes locally, LGTM.
Bumps js-yaml to 4.1.1 and updates ancestor dependencies js-yaml and css-loader. These dependencies need to be updated together.
Updates
js-yamlfrom 4.1.0 to 4.1.1Changelog
Sourced from js-yaml's changelog.
Commits
cc482e74.1.1 released50968b8dist rebuildd092d86lint fix383665ffix prototype pollution in merge (<<)0d3ca7aREADME.md: HTTP => HTTPS (#678)49baadddoc: 'empty' style option for !!nullba3460eFix demo link (#618)Updates
js-yamlfrom 3.14.1 to 3.14.2Changelog
Sourced from js-yaml's changelog.
Commits
cc482e74.1.1 released50968b8dist rebuildd092d86lint fix383665ffix prototype pollution in merge (<<)0d3ca7aREADME.md: HTTP => HTTPS (#678)49baadddoc: 'empty' style option for !!nullba3460eFix demo link (#618)Updates
css-loaderfrom 0.28.11 to 7.1.2Release notes
Sourced from css-loader's releases.
... (truncated)
Changelog
Sourced from css-loader's changelog.
... (truncated)
Commits
d5ba44achore(release): 7.1.276757effix: keep order of@imports with thewebpackIgnorecomment (#1600)4b41689ci: use node v22 (#1596)2068222chore: update dependencies to latest version (#1595)e006f66refactor: useenvironmentto gettemplateLiteralvalue (#1591)5c717c9chore(release): 7.1.1d6c31a1fix: automatically rename classdefaultto_defaultwhen named export is ...b162e25chore(release): 7.1.015f793ddocs: update logic (#1587)9c165a4docs: update migration guide (#1586)Maintainer changes
This version was pushed to npm by evilebottnawi, a new releaser for css-loader since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.