fix: Delete legacy cookie once v4 cookie is set#2019
Merged
frederikprijck merged 1 commit intomainfrom Apr 1, 2025
Merged
Conversation
frederikprijck
changed the title
frederikprijck
force-pushed
the
fix/delete-legacy-cookie-on-logout
branch
2 times, most recently
from
3d1f73d to
f12c5fb
Compare
tusharpandey13
previously approved these changes
Apr 1, 2025
frederikprijck
force-pushed
the
fix/delete-legacy-cookie-on-logout
branch
from
f12c5fb to
4329b7b
Compare
tusharpandey13
approved these changes
Apr 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2019 +/- ##
==========================================
+ Coverage 74.77% 74.82% +0.05%
==========================================
Files 21 21
Lines 1859 1863 +4
Branches 288 289 +1
==========================================
+ Hits 1390 1394 +4
Misses 462 462
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Changes
As reported in #2016, the legacy cookie is not cleanup correctly.
This PR ensures that we clear up the v3 cookie once we have set a v4 cookie.
📎 References
#2016
🎯 Testing