fix: Properly configure SDK to be distributed as ESM#2028
Merged
tusharpandey13 merged 1 commit intomainfrom Apr 3, 2025
Merged
fix: Properly configure SDK to be distributed as ESM#2028tusharpandey13 merged 1 commit intomainfrom
tusharpandey13 merged 1 commit intomainfrom
Conversation
Closed
6 tasks
84da922 to
624dc14
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
=======================================
Coverage 74.82% 74.82%
=======================================
Files 21 21
Lines 1863 1863
Branches 289 289
=======================================
Hits 1394 1394
Misses 462 462
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
panva
approved these changes
Apr 2, 2025
tusharpandey13
approved these changes
Apr 3, 2025
Merged
tusharpandey13
added a commit
that referenced
this pull request
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our SDK isnt correctly configured to publish ESM:
default, notimporttype: modulein the package.jsonThis can cause issues as it may mean certain tools have to rely on auto resolving the module loading and failing as they think our SDK is CJS, but it is ESM.
Solves #1945