Update EXAMPLES.md so that resWithCombinedHeaders accounts for chunked cookies#2503
Open
eliw00d wants to merge 3 commits intoauth0:mainfrom
Open
Update EXAMPLES.md so that resWithCombinedHeaders accounts for chunked cookies#2503eliw00d wants to merge 3 commits intoauth0:mainfrom
resWithCombinedHeaders accounts for chunked cookies#2503eliw00d wants to merge 3 commits intoauth0:mainfrom
Conversation
…ked cookies I ran into an issue where one of the examples was not accounting for multiple `set-cookie` headers in authRes which led to `appSession.1` not being present and so the middleware was unable to decode the JWE. This might be very specific to my use case where I was upgrading to v4 from v3 and using this example to help with getAccessToken being used in some getServerSideProps functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Changes
I ran into an issue where one of the examples was not accounting for multiple
set-cookieheaders in authRes which led toappSession.1not being present and so the middleware was unable to decode the JWE using onlyappSession.0. This might be very specific to my use case where I was upgrading to v4 from v3 and using this example to help withgetAccessTokenbeing used in somegetServerSidePropsfunctions.📎 References
🎯 Testing
After running into this issue I changed the example code to copy all other headers and then copy all cookies to
resWithCombinedHeadersand no longer ran into the issue.