Skip to content

Conversation

@isidrok
Copy link

@isidrok isidrok commented Oct 29, 2024

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

This library is using an outdated version of lru-memoizer, which in turn has a dependency on lru-cache. The lru-cache version it is using is pretty outdated and is no longer compatible with new versions, as a result applications depending on packages that use different versions break when bundling them.

References

Fixes #424

Testing

This should be covered by existing tests

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@isidrok isidrok requested a review from a team as a code owner October 29, 2024 08:58
@isidrok
Copy link
Author

isidrok commented Nov 11, 2024

Hi @evansims could you or some other maintainer have a look at this.

Thanks!

@isidrok
Copy link
Author

isidrok commented Dec 23, 2024

Hi @desusai7, this is causing plenty of trouble in a production application since most packages depend on newer versions of LRU-cache and therefore cant be updated. Can someone please have a look?

Thank you

@cschetan77
Copy link
Contributor

Hi @isidrok ,
First off, sincere apologies for the long delay in getting back to you.

Thank you so much for reporting the issue and for taking the time to put together a PR. That extra effort is genuinely appreciated.

I just wanted to check in and see if you’re still around and interested in continuing with the PR. If so, could you please rebase it on the master branch and double-check that everything still looks good and also sign the commits? It looks like the current commits aren't signed.

Thanks again for your patience.

@isidrok
Copy link
Author

isidrok commented Jan 19, 2026

Hi @cschetan77, I have created a new pr adding a test and signing the commit, lets follow up there #427

@isidrok isidrok closed this Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update lru-memoizer

2 participants