Debugger toolbar component#73
Open
javiert-okta wants to merge 15 commits intohero-jumbotron-componentfrom
Open
Debugger toolbar component#73javiert-okta wants to merge 15 commits intohero-jumbotron-componentfrom
javiert-okta wants to merge 15 commits intohero-jumbotron-componentfrom
Conversation
…penidconnect-playground into debugger-toolbar-component
javiert-okta
had a problem deploying
to
preview
GitHub Actions
Failure
…penidconnect-playground into debugger-toolbar-component
javiert-okta
had a problem deploying
to
preview
GitHub Actions
Failure
|
Preview URL https://openidconnect-27jtn1bm3-okta.vercel.app |
Sambego
reviewed
Mar 4, 2026
|
|
||
| interface DebuggerPickerComponentProps { | ||
| label: string | null; | ||
| options; |
Contributor
There was a problem hiding this comment.
MIssing options type, eg
{
label: string | null;
options: {
"foo": string;
};
}
| placeholder="" | ||
| /> | ||
| <div className={styles.separator_line} /> | ||
| <div className={styles.button_container}> |
Contributor
There was a problem hiding this comment.
Why is this not a <button />?
| interface DebuggerPickerComponentProps { | ||
| label: string | null; | ||
| options; | ||
| isGrouped?: boolean; |
| label: string | null; | ||
| } | ||
|
|
||
| const Select = dynamic(() => import("react-select"), { ssr: false }); |
Contributor
There was a problem hiding this comment.
Why the dynamic import? react-select should work just fine with SSR. https://react-select.com/advanced#ssr---universal-rendering
| }; | ||
|
|
||
| interface DebuggerPickerComponentProps { | ||
| label: string | null; |
Contributor
There was a problem hiding this comment.
Why not make these props optional instead of string | nul, eg:
{
label?: string;
...
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
The following PR adds the debugger toolbar component, which contains a mode picker and a configuration button. The changes include:
react-selectlibrary to create the mode pickerScreenshots
Desktop
Mobile
Desktop
Mobile
References
Link to Figma design
Testing
Checklist