Open
Conversation
|
Preview URL https://openidconnect-hsdutmnik-okta.vercel.app |
|
Preview URL https://openidconnect-n0598fg5k-okta.vercel.app |
Sambego
reviewed
Mar 4, 2026
| }; | ||
| if (authDataResponse.authCode) { | ||
| setCurrentStepIndex(1); | ||
| debuggerSteps.currentStep = 1; |
Contributor
There was a problem hiding this comment.
debuggerSteps is a const from getAppData() return value. This line attempts to mutate it.
setDebuggerStepsData(prev => ({ ...prev, currentStep: 1 }));
| } | ||
| const parsedData = JSON.parse(savedData); | ||
| const validated = AppDataSchema.parse(parsedData); | ||
| const debuggerSteps: DebuggerStepsData = { |
Contributor
There was a problem hiding this comment.
The debuggerSteps object is missing the non-optional currentStep field, even though it's defined in the schema.
| } | ||
| if (auth) setAuthData(auth); | ||
| if (!auth) { | ||
| fetch("api/auth_data") |
Contributor
There was a problem hiding this comment.
This fetchc all does not have any errorhandling
| requestData: RequestData, | ||
| ): string => { | ||
| const { url, params } = requestData; | ||
| const completeUrl = `${url}?${params.map((param, idx) => `${idx > 0 ? "&" : ""}${param.key}=${param.key === "scope" ? encodeURI(param.value) : param.value}`).join("")}`; |
Contributor
There was a problem hiding this comment.
Shouldn't other (than scope) url params be encoded? You could use URLSearchParams to do this.
export const getCompleteUrlFromRequestData = (
requestData: RequestData,
): string => {
const { url, params } = requestData;
const searchParams = new URLSearchParams();
params.forEach(param => {
searchParams.append(param.key, param.value);
});
return `${url}?${searchParams.toString()}`;
};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
The following PR adds the logic to the step one that redirects the request to the auth0 tenant and retrieves the code. The changes include:
Screenshots:
References
Link to Figma design
Testing
IMPORTANT:
The functionality for OIDC can only be tested on a specifically controlled url which is why the following link should be used:
OIDC TESTING URL
Checklist