Open
Conversation
|
Preview URL https://openidconnect-dlb75zd87-okta.vercel.app |
|
Preview URL https://openidconnect-12lxwxhfm-okta.vercel.app |
Sambego
reviewed
Mar 4, 2026
| }); | ||
| }, [currentStepIndex]); | ||
|
|
||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
This runs on every state change. Maybe you can debounce this for performance?
| <div className={styles.button_arrow}> | ||
| <ArrowIcon /> | ||
| </div> | ||
| {isLoading ? ( |
Contributor
There was a problem hiding this comment.
Should the button also be disabled when loading?
| method: requestData.method, | ||
| body: JSON.stringify(bodyFromRequestData(requestData)), | ||
| }); | ||
| setIsLoading(false); |
Contributor
There was a problem hiding this comment.
This won't run if the request fails.
You could use a finally to always reset the loading state
try {...}
catch() {...}
finally {
setIsLoading(false);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
The following PR adds logic to the step three component that exchanges validates the received token and finally decodes it on the next step. The changes include:
Screenshots:
References
Link to Figma design
Testing
IMPORTANT:
The functionality for OIDC can only be tested on a specifically controlled url which is why the following link should be used:
OIDC TESTING URL
Checklist