Open
Conversation
|
Preview URL https://openidconnect-mpvmtq8n7-okta.vercel.app |
Sambego
reviewed
Mar 4, 2026
| label="Save" | ||
| showIcon={false} | ||
| onClick={() => { | ||
| onSaveData(formValues as InitialModalData); |
Contributor
There was a problem hiding this comment.
The form is not validated before saving
| domain: value !== "auth0" ? SERVER_URLS[value] : "samples.auth0.com", | ||
| }; | ||
| }); | ||
| } catch (error) { |
Contributor
There was a problem hiding this comment.
Shouldn't we show an error message instead of just silently clearing the fields?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
The following PR adds the configuration modal component logic, which adds a form submission to let the user handle the OIDC config. The changes include:
Screenshots
Desktop
Desktop
References
Link to Figma design
Testing
Checklist