Compatibility with the New Architecture#341
Merged
tung2744 merged 9 commits intoauthgear:masterfrom Feb 5, 2025
Merged
Conversation
For some unknown reason, the upgrade-helper does not work for 0.74.7 So the from version in the below link is 0.74.6 But 0.74.6 and 0.74.7 are nearly identical. https://react-native-community.github.io/upgrade-helper/?from=0.74.6&to=0.74.7 https://react-native-community.github.io/upgrade-helper/?from=0.74.6&to=0.75.4
It is easier to manage only one native module.
The reference is https://github.com/react-native-device-info/react-native-device-info/blob/master/RNDeviceInfo.podspec It does not have this block. And this block is actually problmatic because it references an undefined variable folly_compiler_flags.
The gist is we need to correct the react {} block.
Collaborator
|
Tested and can build in android and ios |
tung2744
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref DEV-2483
@tung2744 Let's see if you can build and run this too. Some common problems
npm run buildto build the react native SDK first.rm -rf node_modulesinexample/reactnative, and thenyarnto install the just built SDKcd example/reactnative/iosand runpod install.npm startto start the packager manually, it no longer starts itself.