Support WeChat Login in WebKitWebViewUIImplementation#362
Merged
tung2744 merged 13 commits intoauthgear:masterfrom Jun 13, 2025
Merged
Conversation
1. Add wechatRedirectURI to WebKitWebViewUIImplementation construction options. 2. (Implementation details) Use native events to forward the open wechat action. 3. Remove no-op application: ... calls in AppDelegate.mm 4. Fix wechat is not opened in main thread
In a latter commit, we are going to add BroadcastReceiver to Handle.
louischan-oursky
force-pushed
the
dev-2761-support-wechat-login-in-wkwebview
branch
from
b05e7f1 to
e71e5ef
Compare
louischan-oursky
changed the title
tung2744
reviewed
Jun 13, 2025
Comment on lines
+30
to
+36
| # NOTE(louis): The Authgear SDK is not compatible with the new arch. | ||
| # Use this property to enable support to the new architecture. | ||
| # This will allow you to use TurboModules and the Fabric render in | ||
| # your application. You should enable this flag either if you want | ||
| # to write custom TurboModules/Fabric components OR use libraries that | ||
| # are providing them. | ||
| newArchEnabled=true | ||
| newArchEnabled=false |
Collaborator
There was a problem hiding this comment.
What will happen if we set true here?
Even our sdk is not using new arch, we might also want to ensure it can run in an app using new arch?
Contributor
Author
There was a problem hiding this comment.
It does not build at all. I did not spend time investigating why.
tung2744
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref DEV-2810