Skip to content

Always use refreshAccessTokenIfNeeded to refresh access token #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louischan-oursky merged 1 commit into from
Sep 25, 2025
Merged

Always use refreshAccessTokenIfNeeded to refresh access token #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/authgear-core/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,7 @@ export class _BaseAPIClient {
throw new AuthgearError("missing delegate in api client");
}

const shouldRefresh = this._delegate.shouldRefreshAccessToken();
if (shouldRefresh) {
await this._delegate.refreshAccessToken();
}
await this._delegate.refreshAccessTokenIfNeeded();

const request = new this._Request(input, init);

Expand Down
8 changes: 1 addition & 7 deletions packages/authgear-core/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,16 +151,10 @@ export interface _APIClientDelegate {
*/
getAccessToken(): string | undefined;

/**
* Called by the API Client before sending HTTP request.
* If true is returned, refreshAccessToken() is then called.
*/
shouldRefreshAccessToken(): boolean;

/**
* Called by the API client to refresh the access token.
*/
refreshAccessToken(): Promise<void>;
refreshAccessTokenIfNeeded(): Promise<void>;
}

/**
Expand Down