Skip to content

Support add login id setting actions #5001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louischan-oursky merged 12 commits into from
Feb 4, 2025
Merged

Support add login id setting actions #5001

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2e30ddb
Add new settings actions for adding login id
tung2744 Jan 23, 2025
e96dbf7
Provide login id key in the url
tung2744 Jan 23, 2025
fabc3a2
Support setting action add email in webapp
tung2744 Jan 24, 2025
2cd2333
Support setting action add phone in webapp
tung2744 Jan 24, 2025
bdd1713
Support setting action add username in webapp
tung2744 Jan 24, 2025
338d8f9
Reduce code duplication by creating a method to finish and redirect t…
tung2744 Jan 24, 2025
46fc5b6
Return a protocol error when login id create is disabled
tung2744 Jan 24, 2025
19ad944
Fix settings error alert is missing spaces in mobile
tung2744 Jan 24, 2025
4a706d0
Fix otp input is not center aligning boxes
tung2744 Jan 24, 2025
66f5e40
Change ErrInvalidSettingsAction to protocol error
tung2744 Feb 4, 2025
6e5d395
Fix a typo
tung2744 Feb 4, 2025
b27ad72
Update .vettedpositions
tung2744 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/lib/oauth/handler/handler_authz.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,9 @@ func (h *AuthorizationHandler) handleSettingsAction(
) (httputil.Result, error) {
redirectURI, err := h.UIURLBuilder.BuildSettingsActionURL(client, r, oauthSessionEntry)
if err != nil {
if apierrors.IsKind(err, oidc.ErrInvalidSettingsAction) {
return nil, protocol.NewError("invalid_request", apierrors.AsAPIError(err).Message)
}
return nil, err
}
loginHintString, loginHintOk := r.LoginHint()
Expand Down