Allow specifying order for dropdown menu items#92
Open
bs2609 wants to merge 1 commit intoauthorblues:mainfrom
Open
Allow specifying order for dropdown menu items#92bs2609 wants to merge 1 commit intoauthorblues:mainfrom
bs2609 wants to merge 1 commit intoauthorblues:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new optional property
orderedfor dropdown-type settings, which allows specifying the order the dropdown items should appear in. Currently, all dropdown items are unconditionally sorted alphabetically and it would be good to have a way to override this (somewhat unexpected) behaviour for settings that may have a logical ordering that is non-alphabetical.With this change, if
ordered = trueis defined,optionswill be taken to be an ordered list and passed tosetdropdownitemsas such. Otherwise, existing behaviour is preserved.The corresponding wiki page will also need updating to mention the additional
orderedkey forselecttype options.Example usage:
{ name='testing', type='select', label="test setting please ignore", options={'la','li','lu','le','lo'}, ordered=true }