Feature, separate HttpOnly cookie attribute APP_COOKIE_HTTPONLY #471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Which issue(s) does this PR fix?
This does not directly address an issue. This allows webdevs to run authorizer instances in a test environment without setting up Https. This is done by APP_COOKIE_SECURE=false, and with this PR, now without disabling HttpOnly cookie attribute.
Why? WEBKIT CLIENT TESTING
This allows test and application code to run normally (expecting HttpOnly cookies) while allowing webkit clients to receive data without setting up Https proxies and further complicating the test environment. Webkit only allows cookies to be stored over non-TLS connections with Secure attribute disabled. This update allows webdevs to test with webkit clients without setting up TLS proxies on localhost like other browsers (firefox, chromium).
If this PR affects any API reference documentation, please share the updated endpoint references
This PR adds another undocumented Environment Variable (alongside APP_COOKIE_SECURE) APP_COOKIE_HTTPONLY. This allows APP_COOKIE_SECURE to be disabled without effecting the HttpOnly attribute.
This PR adds makefile test
make test-debugand documentation in CONTRIBUTING.md was updated to reflect this. I had to use this to debug/fix the existing tests.