Change appAttestation from object to boolean flag#84
Closed
stevenclouston wants to merge 4 commits intomainfrom
Closed
Change appAttestation from object to boolean flag#84stevenclouston wants to merge 4 commits intomainfrom
stevenclouston wants to merge 4 commits intomainfrom
Conversation
Remove AppAttestationProvider enum from public API. Provider is now hardcoded internally by each native SDK (APP_ATTEST for iOS, PLAY_INTEGRITY for Android). AppAttestation interface now just takes token and optional keyId. Also bumps native SDK deps and version to 2.8.0-alpha.2.
The native SDKs now generate attestation internally, so callers only need to signal whether attestation should be enabled rather than passing the attestation token and keyId.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appAttestationparameter fromAppAttestationobject ({ token, keyId }) to abooleanflagAppAttestationTypeScript interface (no longer needed on the JS side)Depends on
Test plan
addCredential({ appAttestation: true })triggers App Attest and enrolls successfullyaddCredential({})(no attestation) still works