-
Notifications
You must be signed in to change notification settings - Fork 46
chore: move retries to separate section and document ResourceExhausted #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bcb7bc1 to
3f554c8
Compare
3f554c8 to
d3e1c27
Compare
barakmich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with optional fix
pages/spicedb/ops/resilience.mdx
Outdated
| * You may want to leave additional headroom to allow a new instance to come into service without exhausting connections, depending on your deployment model | ||
| and how instances roll. | ||
|
|
||
| #### CockroachDB fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
match caps
pages/spicedb/ops/resilience.mdx
Outdated
|
|
||
| #### Postgres Fix | ||
|
|
||
| * Ensure that Postgres has enough available connections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would these bullets read better as h5s instead of bullet/subbullet? Eg:
##### Available Connections
Ensure that Postgres has enough available connections.
....
##### Connection Pooling
##### Connection Flags
Same also with Cockroach, below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might actually wanna use steps? https://nextra.site/docs/built-ins/steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| @@ -6,52 +6,6 @@ import { Callout } from 'nextra/components' | |||
| This page will provide some practical recommendations for writing relationships to SpiceDB. | |||
| If you are interested in relationships as a concept, check out this [page](/spicedb/concepts/relationships). | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good split!
Should there be a small reference to the resilience page here ? Something like: "If you want to focus on more reliable operations with your app, go here (with link to the resilience page)"
|
additional feedback:
|
d3e1c27 to
00ba6ea
Compare
00ba6ea to
2c8c76e
Compare
tstirrat15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
| @@ -1,5 +1,6 @@ | |||
| /// <reference types="next" /> | |||
| /// <reference types="next/image-types/global" /> | |||
| /// <reference types="next/navigation-types/compat/navigation" /> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an automatic change on running pnpm run dev; it should be fine.
| "yaml-loader": "^0.8.1" | ||
| }, | ||
| "packageManager": "pnpm@10.17.1" | ||
| "packageManager": "pnpm@10.24.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm told me about this so I did it.
| ## Retries | ||
|
|
||
| When making requests to SpiceDB, it's important to implement proper retry logic to handle transient failures. | ||
| The [SpiceDB Client Libraries](/spicedb/getting-started/client-libraries) use gRPC[^1], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Footnote syntax now works!
2c8c76e to
e559981
Compare
Fixes #414
Description
We got a few questions about what
ResourceExhaustedmeans. This splits out aResiliencepage and elaborates on whatResourceExhaustedmeans and what might cause it.Changes
See above.
Testing
Review.