Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tstirrat15
commented
Feb 5, 2026
Contributor
Author
There was a problem hiding this comment.
New ShadCN components; don't need to review these
Comment on lines
-195
to
-199
| docsLink: { | ||
| [theme.breakpoints.down("sm")]: { | ||
| display: "none", | ||
| }, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
This logic is now handled by tailwind classes on a span in DocLink.
Comment on lines
-276
to
-281
| btnAccept: { | ||
| "& .MuiSvgIcon-root": { | ||
| fill: theme.palette.success.main, | ||
| }, | ||
| color: theme.palette.getContrastText(theme.palette.success.main), | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
This is now handled with button variants
| ) => { | ||
| const type = value ? value.toString() : "grid"; | ||
| if (type === "grid" && services.problemService.invalidRelationships.length > 0) { | ||
| const handleChangeRelationshipEditor = (value: string) => { |
Contributor
Author
There was a problem hiding this comment.
The ToggleGroup from ShadCN has a nicer handle with onValueChange, so we don't need the stuff that's checking for a string value
| <DISCORD viewBox="0 0 71 55" style={{ height: "1em", width: "1em" }} /> | ||
| {/* TODO: make sure this works and then do it elsewhere */} | ||
| <span className="md:hidden">Discuss on Discord</span> | ||
| <span className="hidden md:inline">Discuss on Discord</span> |
Contributor
Author
There was a problem hiding this comment.
This is the idiom for "hide text on small viewports"
| title="Grid Editor" | ||
| disabled={services.problemService.invalidRelationships.length > 0} | ||
| > | ||
| <Tooltip title="Grid Editor"> |
Contributor
Author
There was a problem hiding this comment.
Don't need Tooltips if you use the native title HTML feature
alecmerdler
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #99, I accidentally committed some in-progress work on swapping out material UI buttons for ShadCN buttons that left the UI in a kind of jank state:
This fixes that and finishes the migration.
Changes
Testing
Review. Compare this preview to https://playground-git-temp-backout-authzed.vercel.app/ to see that things look good.