Skip to content

Fix relationship editor column offset bugs #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miparnisari merged 2 commits into from
Mar 17, 2026
+4 −6
Merged

Fix relationship editor column offset bugs #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e20409c
fix: relationship editor column offset bugs
ivanauth Feb 17, 2026
8cda6d5
retrigger CI
ivanauth Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/relationshipeditor/RelationshipEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,8 +601,7 @@ export function RelationshipEditor({
return false;
}

const [oneIndexedColumn, startingRow] = target;
const startingCol = oneIndexedColumn - 1; // col is +1 for the checkbox.
const [startingCol, startingRow] = target;

let adjustedData = inFlightData.current;
let rowOffset = 0;
Expand Down
7 changes: 3 additions & 4 deletions src/components/relationshipeditor/columns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ export const COLUMNS: Column[] = [
group: "Resource",
dataKind: DataKind.RESOURCE_TYPE,
section: RelationshipSection.RESOURCE,
trailingRowOptions: {
hint: "Add relationship",
},
dataDescription: "definition name",
},
{
Expand All @@ -116,10 +119,6 @@ export const COLUMNS: Column[] = [
group: "Resource",
dataKind: DataKind.RESOURCE_ID,
section: RelationshipSection.RESOURCE,
trailingRowOptions: {
hint: "Add relationship",
targetColumn: 0,
},
dataDescription: "object ID",
},
{
Expand Down
Loading