Skip to content

Comments

fix: loading of examples#92

Merged
miparnisari merged 2 commits intomainfrom
fix-load-examples
Dec 12, 2025
Merged

fix: loading of examples#92
miparnisari merged 2 commits intomainfrom
fix-load-examples

Conversation

@miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Dec 12, 2025 •
edited
Loading

I tried to bring the latest examples repo and it failed to load because this example doesn't have the schema-and-data.yaml file.

image image

@vercel
Copy link

vercel bot commented Dec 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
playground Ready Ready Preview, Comment Dec 12, 2025 11:09pm

barakmich
barakmich previously approved these changes Dec 12, 2025
View reviewed changes
tstirrat15
tstirrat15 previously approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, has a test failure.

src/spicedb-common/examples.ts
const match = path.match(/\/examples\/schemas\/(.*)\/README\.md/);
return match ? match[1] : "";
})
.filter((name): name is string => {
Copy link
Contributor

@tstirrat15 tstirrat15 Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHAT! I didn't realize this was valid syntax

Copy link
Contributor Author

@miparnisari miparnisari Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't know either (i don't know typescript), this was written by Claude 😆
https://www.typescriptlang.org/docs/handbook/2/narrowing.html#using-type-predicates

@tstirrat15
Copy link
Contributor

tstirrat15 commented Dec 12, 2025

Though I guess if eager isn't necessary I'd prefer to avoid it - one of the benefits of using it is that the content isn't loaded until it's actually necessary.

@miparnisari miparnisari dismissed stale reviews from tstirrat15 and barakmich via cd5b3f4 December 12, 2025 23:09
@miparnisari
Copy link
Contributor Author

miparnisari commented Dec 12, 2025

Though I guess if eager isn't necessary I'd prefer to avoid it - one of the benefits of using it is that the content isn't loaded until it's actually necessary.

True, i brought this because it makes the code easier to read (no more promises or async/awaits)

The size of the playground is huge anyway, with the wasm stuff..

@tstirrat15
Copy link
Contributor

tstirrat15 commented Dec 12, 2025

Mmm yeah. And we're a ways off of wanting to run vite-bundle-analyzer on it because we have other things that we know are problems, like using MaterialUI. Makes sense.

tstirrat15
tstirrat15 approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miparnisari miparnisari merged commit f8fa704 into main Dec 12, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tstirrat15 tstirrat15 tstirrat15 approved these changes

@barakmich barakmich barakmich left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miparnisari @tstirrat15 @barakmich