feat: allow underscore prefix for private identifiers

.github/workflows/build-test.yaml

@@ -53,7 +53,7 @@ jobs:
       needs.paths-filter.outputs.codechange == 'true'
     steps:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - uses: "docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef" # v3.6.0
         with:
           username: "${{ env.DOCKERHUB_PUBLIC_USER }}"
@@ -72,7 +72,7 @@ jobs:
       needs.paths-filter.outputs.codechange == 'true'
     steps:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - name: "Unit tests with coverage"
         run: "go run mage.go test:unitCover"
       - name: "Coverage"
@@ -90,7 +90,7 @@ jobs:
       needs.paths-filter.outputs.codechange == 'true'
     steps:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - name: "Steelthread tests"
         run: "go run mage.go test:steelthread"
 
@@ -102,7 +102,7 @@ jobs:
       needs.paths-filter.outputs.codechange == 'true'
     steps:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - uses: "docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef" # v3.6.0
         with:
           username: "${{ env.DOCKERHUB_PUBLIC_USER }}"
@@ -128,7 +128,7 @@ jobs:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
         if: |
           needs.paths-filter.outputs.codechange == 'true'
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
         if: |
           needs.paths-filter.outputs.codechange == 'true'
       - uses: "docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef" # v3.6.0
@@ -162,7 +162,7 @@ jobs:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
         if: |
           needs.paths-filter.outputs.codechange == 'true'
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
         if: |
           needs.paths-filter.outputs.codechange == 'true'
       - uses: "docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef" # v3.6.0
@@ -197,7 +197,7 @@ jobs:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
         if: |
           needs.paths-filter.outputs.codechange == 'true'
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
         if: |
           needs.paths-filter.outputs.codechange == 'true'
       - uses: "docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef" # v3.6.0
@@ -232,7 +232,7 @@ jobs:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
         if: |
           needs.paths-filter.outputs.codechange == 'true'
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
         if: |
           needs.paths-filter.outputs.codechange == 'true'
       - uses: "docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef" # v3.6.0
@@ -267,7 +267,7 @@ jobs:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
         if: |
           needs.paths-filter.outputs.codechange == 'true'
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
         if: |
           needs.paths-filter.outputs.codechange == 'true'
       - uses: "docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef" # v3.6.0
@@ -302,7 +302,7 @@ jobs:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
         if: |
           needs.paths-filter.outputs.codechange == 'true'
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
         if: |
           needs.paths-filter.outputs.codechange == 'true'
       - uses: "docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef" # v3.6.0
@@ -336,7 +336,7 @@ jobs:
       needs.paths-filter.outputs.codechange == 'true'
     steps:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
         with:
           go-version-file: "e2e/go.mod"
           cache-dependency-path: "e2e/go.sum"
@@ -357,7 +357,7 @@ jobs:
       needs.paths-filter.outputs.codechange == 'true'
     steps:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
         with:
           go-version-file: "tools/analyzers/go.mod"
           cache-dependency-path: "tools/analyzers/go.sum"
@@ -371,7 +371,7 @@ jobs:
       needs.paths-filter.outputs.codechange == 'true'
     steps:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - name: "Disable AppArmor"
         if:
           "runner.os == 'Linux'"
@@ -397,7 +397,7 @@ jobs:
       needs.paths-filter.outputs.protochange == 'true'
     steps:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - name: "Generate Protos"
         run: "go run mage.go gen:proto"
       - uses: "chainguard-dev/actions/nodiff@3e8a2a226fad9e1ecbf2d359b8a7697554a4ac6d" # main

.github/workflows/lint.yaml

@@ -18,7 +18,7 @@ jobs:
     runs-on: "depot-ubuntu-24.04-small"
     steps:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - name: "Check Licenses"
         uses: "authzed/actions/go-license-check@11667c9b2e8b3649ad2af4d788e57d18f8e8eaf1" # main
         with:
@@ -28,7 +28,7 @@ jobs:
     runs-on: "depot-ubuntu-24.04-4"
     steps:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - name: "Generate docs"
         run: "go run mage.go gen:docs"
       - uses: "chainguard-dev/actions/nodiff@3e8a2a226fad9e1ecbf2d359b8a7697554a4ac6d" # main
@@ -40,7 +40,7 @@ jobs:
     runs-on: "depot-ubuntu-24.04-4"
     steps:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - name: "Lint Everything"
         run: "go run mage.go lint:all"
       - uses: "chainguard-dev/actions/nodiff@3e8a2a226fad9e1ecbf2d359b8a7697554a4ac6d" # main

.github/workflows/nightly.yaml

@@ -16,7 +16,7 @@ jobs:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
         with:
           fetch-depth: 0
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - name: "Install snapcraft"
         run: |
           sudo snap install snapcraft --channel=8.x/stable --classic

.github/workflows/release-windows.yaml

@@ -16,7 +16,7 @@ jobs:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
         with:
           fetch-depth: 0
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - uses: "nowsprinting/check-version-format-action@bb1181a02ee5d9ae4feead2842236183c85152c6" # v4.0.7
         id: "version"
         with:

.github/workflows/release.yaml

@@ -17,7 +17,7 @@ jobs:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
         with:
           fetch-depth: 0
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - uses: "nowsprinting/check-version-format-action@bb1181a02ee5d9ae4feead2842236183c85152c6" # v4.0.7
         id: "version"
         with:

.github/workflows/security.yaml

@@ -36,7 +36,7 @@ jobs:
 
     steps:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - uses: "authzed/actions/codeql@11667c9b2e8b3649ad2af4d788e57d18f8e8eaf1" # main"
 
   trivy:
@@ -52,7 +52,7 @@ jobs:
           # this is used so goreleaser generates the right version out of the tags, which we need so that
           # trivy does not flag an old SpiceDB version
           fetch-depth: 0
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - uses: "docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef" # v3.6.0
         with:
           username: "${{ env.DOCKERHUB_PUBLIC_USER }}"

.github/workflows/wasm.yaml

@@ -15,7 +15,7 @@ jobs:
       - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v4.2.2
         with:
           ref: "${{ env.GITHUB_SHA }}"
-      - uses: "authzed/actions/setup-go@6cde6aeb82fab36d8383c2f55bed8128955af34d" # main
+      - uses: "authzed/actions/setup-go@882cac020050006e1829bd3cb1f90f4fe1b99cd6" # main
       - name: "Build WASM"
         run: "go run mage.go build:wasm"
       - uses: "shogo82148/actions-upload-release-asset@8f6863c6c894ba46f9e676ef5cccec4752723c1e" # v1.9.2

pkg/composableschemadsl/compiler/compiler_test.go

@@ -769,7 +769,7 @@ func TestCompile(t *testing.T) {
 			"invalid definition name",
 			nilPrefix,
 			`definition someTenant/fo {}`,
-			"parse error in `invalid definition name`, line 1, column 1: error in object definition someTenant/fo: invalid NamespaceDefinition.Name: value does not match regex pattern \"^([a-z][a-z0-9_]{1,62}[a-z0-9]/)*[a-z][a-z0-9_]{1,62}[a-z0-9]$\"",
+			"parse error in `invalid definition name`, line 1, column 1: error in object definition someTenant/fo: invalid NamespaceDefinition.Name: value does not match regex pattern \"^([a-z_][a-z0-9_]{1,62}[a-z0-9]/)*[a-z_][a-z0-9_]{1,62}[a-z0-9]$\"",
 			[]SchemaDefinition{},
 		},
 		{
@@ -778,7 +778,7 @@ func TestCompile(t *testing.T) {
 			`definition some_tenant/foos {
 				relation ab: some_tenant/foos
 			}`,
-			"parse error in `invalid relation name`, line 2, column 5: error in relation ab: invalid Relation.Name: value does not match regex pattern \"^[a-z][a-z0-9_]{1,62}[a-z0-9]$\"",
+			"parse error in `invalid relation name`, line 2, column 5: error in relation ab: invalid Relation.Name: value does not match regex pattern \"^[a-z_][a-z0-9_]{1,62}[a-z0-9]$\"",
 			[]SchemaDefinition{},
 		},
 		{

pkg/development/wasm/operations_test.go

@@ -131,7 +131,7 @@ func TestCheckOperation(t *testing.T) {
 			tuple.MustParse("somenamespace:someobj#anotherrel@user:foo"),
 			nil,
 			&devinterface.DeveloperError{
-				Message: "error in object definition fo: invalid NamespaceDefinition.Name: value does not match regex pattern \"^([a-z][a-z0-9_]{1,62}[a-z0-9]/)*[a-z][a-z0-9_]{1,62}[a-z0-9]$\"",
+				Message: "error in object definition fo: invalid NamespaceDefinition.Name: value does not match regex pattern \"^([a-z_][a-z0-9_]{1,62}[a-z0-9]/)*[a-z_][a-z0-9_]{1,62}[a-z0-9]$\"",
 				Kind:    devinterface.DeveloperError_SCHEMA_ISSUE,
 				Source:  devinterface.DeveloperError_SCHEMA,
 				Line:    1,