test: reduce flakiness of RegisterRelationshipCountersInParallelTest#2820
test: reduce flakiness of RegisterRelationshipCountersInParallelTest#2820miparnisari merged 2 commits intomainfrom
Conversation
github-actions
bot
added
area/datastore
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2820 +/- ##
==========================================
+ Coverage 74.42% 74.45% +0.03%
==========================================
Files 487 487
Lines 60218 60218
==========================================
+ Hits 44814 44827 +13
+ Misses 12254 12241 -13
Partials 3150 3150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hmm... The memdb tests are already spinning up a separate memdb instance per test, so it's not likely resource contention within a single database. |
| func TestMemdbDatastore(t *testing.T) { | ||
| t.Parallel() | ||
| test.All(t, memDBTest{}, true) | ||
| // NOTE: The individual tests are not parallelized because enough write traffic will cause |
There was a problem hiding this comment.
i don't understand how this fixes things. Each individual test is creating its own memdb instance. For example:
func RegisterRelationshipCountersInParallelTest(t *testing.T, tester DatastoreTester) {
rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)could it be that the default number of retries is 10 and this test is doing 10 parallel writes?
There was a problem hiding this comment.
oh hmmm... yeah I suppose we could reduce it to 9 and see if that helps?
There was a problem hiding this comment.
yeah. but don't harcode to 9, use numAttempts - 1 and maybe rename numAttempts to defaultNumAttempts :P
miparnisari
force-pushed
the
reduce-memdb-test-flakes
branch
2 times, most recently
from
9186cf3 to
6a50235
Compare
miparnisari
changed the title
miparnisari
force-pushed
the
reduce-memdb-test-flakes
branch
from
6a50235 to
4e871ac
Compare
github-actions
bot
removed
the
area/tooling
tstirrat15
left a comment
tstirrat15
left a comment
There was a problem hiding this comment.
LGTM but I can't approve it because I opened it
2 participants
Description
See https://github.com/authzed/spicedb/actions/runs/21007920564/job/60396619281?pr=2818. We were getting test flakes from write failures that were the result of too much load on the memdb instance. For this reason, we're allowing the set of Memdb tests to run in parallel with other tests, but the test itself will not be parallelized to ensure that we aren't hammering the instance.
Changes
Testing
Review.