fix(cluster): improve streaming dispatch logging and observability#2915
Merged
vroldanbet merged 6 commits intomainfrom Feb 24, 2026
Merged
fix(cluster): improve streaming dispatch logging and observability#2915vroldanbet merged 6 commits intomainfrom
vroldanbet merged 6 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (74.52%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2915 +/- ##
==========================================
+ Coverage 74.51% 74.52% +0.02%
==========================================
Files 484 484
Lines 59201 59242 +41
==========================================
+ Hits 44109 44146 +37
- Misses 11995 11999 +4
Partials 3097 3097 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ef97cd9 to
16c885e
Compare
…se a non-empty placeholder
in order to properly see the order of events in logs
Helps log aggregators present log entries in the right order.
and improve readability of other log entries
16c885e to
df196e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log.Ctx(ctx)throughout all dispatch log calls (trace/warn/debug) so request-scoped fields (e.g.requestID) are included in every log linezerolog.TimeFieldFormat = time.RFC3339Nanoglobally and addWithTimestampFormat(time.RFC3339Nano)to all gRPC log interceptors, helping log aggregators order events correctly""with$$no_dispatcher_resultsconstant as the initial value ofreturnedResultsDispatcherName, making the no-results vs. empty-name distinction explicit and preventing a silent bugwithTimeout→ctxWithTimeoutto avoid var shadowing, pass context explicitly toaddResultTime, pass handler context explicitly torunHandler, add guard against empty dispatcher namesTest plan
go test ./internal/dispatch/remote/...requestIDand nanosecond timestamps for dispatch-related log lines🤖 Generated with Claude Code