Skip to content

feat: add unified schema storage with ReadStoredSchema/WriteStoredSchema #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josephschorr wants to merge 1 commit into
base: main
Choose a base branch
from
+9,240 −704

feat: add unified schema storage with ReadStoredSchema/WriteStoredSchema

0ccb2b1
Select commit
Loading
Failed to load commit list.
Open

feat: add unified schema storage with ReadStoredSchema/WriteStoredSchema #2924

feat: add unified schema storage with ReadStoredSchema/WriteStoredSchema
0ccb2b1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 12, 2026 in 0s

74.92% (target 75.00%)

View this Pull Request on Codecov

74.92% (target 75.00%)

Details

Codecov Report

❌ Patch coverage is 70.74236% with 335 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.92%. Comparing base (b554261) to head (0ccb2b1).

Files with missing lines Patch % Lines
internal/datastore/spanner/schema_chunker.go 48.72% 36 Missing and 4 partials ⚠️
pkg/datalayer/impl.go 55.96% 32 Missing and 5 partials ⚠️
internal/datastore/mysql/schema_chunker.go 50.82% 24 Missing and 6 partials ⚠️
pkg/datalayer/hashcache.go 73.69% 17 Missing and 8 partials ⚠️
internal/datastore/crdb/schema_chunker.go 55.56% 20 Missing and 4 partials ⚠️
internal/datastore/postgres/schema_chunker.go 52.00% 20 Missing and 4 partials ⚠️
internal/datastore/memdb/storedschema.go 51.17% 14 Missing and 7 partials ⚠️
internal/datastore/proxy/proxy_test/mock.go 0.00% 17 Missing ⚠️
pkg/datalayer/schema_adapter.go 90.29% 12 Missing and 5 partials ⚠️
internal/datastore/common/sqlschema.go 82.76% 7 Missing and 3 partials ⚠️
... and 19 more

❌ Your project check has failed because the head coverage (74.92%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2924      +/-   ##
==========================================
+ Coverage   74.83%   74.92%   +0.10%     
==========================================
  Files         497      509      +12     
  Lines       60621    61508     +887     
==========================================
+ Hits        45359    46081     +722     
- Misses      12103    12224     +121     
- Partials     3159     3203      +44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov