Skip to content

test(query): Add a new benchmark for wide arrows#2927

Merged
barakmich merged 1 commit intomainfrom
barakmich/wide_arrow_benchmark
Mar 3, 2026
Merged

test(query): Add a new benchmark for wide arrows#2927
barakmich merged 1 commit intomainfrom
barakmich/wide_arrow_benchmark

Conversation

@barakmich
Copy link
Contributor

Description

Testing

References

@barakmich barakmich requested a review from a team as a code owner February 28, 2026 00:32
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Feb 28, 2026
@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.50%. Comparing base (b275f07) to head (7011fa9).

❌ Your project check has failed because the head coverage (74.50%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2927       +/-   ##
===========================================
+ Coverage   48.95%   74.50%   +25.55%     
===========================================
  Files         422      489       +67     
  Lines       54286    60356     +6070     
===========================================
+ Hits        26570    44960    +18390     
+ Misses      24997    12242    -12755     
- Partials     2719     3154      +435     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@barakmich barakmich force-pushed the barakmich/wide_arrow_benchmark branch from e3d88e8 to 5d4315e Compare March 2, 2026 18:06
CHANGELOG.md Outdated
Comment on lines +7 to +8
### Added
- testing(query planner): add a wide arrow benchmark to test query plan performance in the small (#2927)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this; this change has no impact to end users. add the label skip-changelog to the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and did this. But, further conversation here.

b.ResetTimer()

// Run the benchmark
for b.Loop() {
Copy link
Contributor

@miparnisari miparnisari Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL b.Loop!

// Loop resets the benchmark timer the first time it is called in a benchmark,
// so any setup performed prior to starting the benchmark loop does not count
// toward the benchmark measurement. Likewise, when it returns false, it stops
// the timer so cleanup code is not measured.

// Prior to the introduction of Loop, benchmarks were expected to contain an
// explicit loop from 0 to b.N. Benchmarks should either use Loop or contain a
// loop to b.N, but not both. Loop offers more automatic management of the
// benchmark timer, and runs each benchmark function only once per measurement,
// whereas b.N-based benchmarks must run the benchmark function (and any
// associated setup and cleanup) several times.

@barakmich barakmich force-pushed the barakmich/wide_arrow_benchmark branch from 01414d0 to 939ba26 Compare March 3, 2026 16:50
@barakmich barakmich force-pushed the barakmich/wide_arrow_benchmark branch 2 times, most recently from df855da to 7011fa9 Compare March 3, 2026 18:35
@barakmich barakmich enabled auto-merge (squash) March 3, 2026 19:11
@barakmich barakmich merged commit 8181b86 into main Mar 3, 2026
44 of 46 checks passed
@barakmich barakmich deleted the barakmich/wide_arrow_benchmark branch March 3, 2026 19:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) Skip-Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants