test(query): Add a new benchmark for wide arrows#2927
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (74.50%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2927 +/- ##
===========================================
+ Coverage 48.95% 74.50% +25.55%
===========================================
Files 422 489 +67
Lines 54286 60356 +6070
===========================================
+ Hits 26570 44960 +18390
+ Misses 24997 12242 -12755
- Partials 2719 3154 +435 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e3d88e8 to
5d4315e
Compare
CHANGELOG.md
Outdated
| ### Added | ||
| - testing(query planner): add a wide arrow benchmark to test query plan performance in the small (#2927) |
There was a problem hiding this comment.
please remove this; this change has no impact to end users. add the label skip-changelog to the PR
There was a problem hiding this comment.
I went ahead and did this. But, further conversation here.
| b.ResetTimer() | ||
|
|
||
| // Run the benchmark | ||
| for b.Loop() { |
There was a problem hiding this comment.
TIL b.Loop!
// Loop resets the benchmark timer the first time it is called in a benchmark,
// so any setup performed prior to starting the benchmark loop does not count
// toward the benchmark measurement. Likewise, when it returns false, it stops
// the timer so cleanup code is not measured.
// Prior to the introduction of Loop, benchmarks were expected to contain an
// explicit loop from 0 to b.N. Benchmarks should either use Loop or contain a
// loop to b.N, but not both. Loop offers more automatic management of the
// benchmark timer, and runs each benchmark function only once per measurement,
// whereas b.N-based benchmarks must run the benchmark function (and any
// associated setup and cleanup) several times.
01414d0 to
939ba26
Compare
df855da to
7011fa9
Compare
Description
Testing
References