chore(services): store observed counts in permissionsServer#2929
Draft
chore(services): store observed counts in permissionsServer#2929
Conversation
github-actions
bot
added
area/api v1
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (52.19%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
===========================================
- Coverage 74.55% 52.19% -22.36%
===========================================
Files 489 217 -272
Lines 60365 22971 -37394
===========================================
- Hits 44998 11987 -33011
+ Misses 12219 9694 -2525
+ Partials 3148 1290 -1858 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
barakmich
force-pushed
the
barakmich/ps_counts
branch
from
e95f9b9 to
0bd1e09
Compare
miparnisari
reviewed
Mar 3, 2026
| // This allows tracking which parts of query plans are used most frequently. | ||
| type QueryPlanMetadata struct { | ||
| mu sync.Mutex | ||
| stats map[query.CanonicalKey]query.CountStats // GUARDED_BY(mu) |
Contributor
There was a problem hiding this comment.
should we put a cap on how much this map can grow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
References