Skip to content

chore: use correct logger in import logic#2937

Merged
tstirrat15 merged 1 commit intomainfrom
tstirrat/use-correct-logger
Mar 2, 2026
Merged

chore: use correct logger in import logic#2937
tstirrat15 merged 1 commit intomainfrom
tstirrat/use-correct-logger

Conversation

@tstirrat15
Copy link
Contributor

Description

I used the incorrect logger when I originally wrote this, and then I copied it when I moved import logic into schemadsl. This fixes it.

Changes

  • Use our internal logging package instead of a bare reference to zerolog

Testing

Review.

@tstirrat15 tstirrat15 requested a review from a team as a code owner March 2, 2026 21:32
@github-actions github-actions bot added the area/schema Affects the Schema Language label Mar 2, 2026
@tstirrat15 tstirrat15 force-pushed the tstirrat/use-correct-logger branch from 07cc6a9 to 2fed801 Compare March 2, 2026 21:34
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.53%. Comparing base (a01eddc) to head (2fed801).
⚠️ Report is 2 commits behind head on main.

❌ Your project status has failed because the head coverage (74.53%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2937      +/-   ##
==========================================
- Coverage   74.55%   74.53%   -0.01%     
==========================================
  Files         489      489              
  Lines       60365    60365              
==========================================
- Hits        44998    44990       -8     
- Misses      12219    12224       +5     
- Partials     3148     3151       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tstirrat15 tstirrat15 merged commit a2a1465 into main Mar 2, 2026
44 of 46 checks passed
@tstirrat15 tstirrat15 deleted the tstirrat/use-correct-logger branch March 2, 2026 21:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/schema Affects the Schema Language Skip-Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants