refactor: remove metrics that are not useful or not written to#2941
Merged
miparnisari merged 1 commit intomainfrom Mar 3, 2026
Merged
refactor: remove metrics that are not useful or not written to#2941miparnisari merged 1 commit intomainfrom
miparnisari merged 1 commit intomainfrom
Conversation
github-actions
bot
added
area/datastore
miparnisari
force-pushed
the
remove-unwritten-metrics
branch
from
adb9e65 to
b625384
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (74.58%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2941 +/- ##
==========================================
+ Coverage 74.53% 74.58% +0.05%
==========================================
Files 489 489
Lines 60365 60356 -9
==========================================
+ Hits 44986 45009 +23
+ Misses 12229 12201 -28
+ Partials 3150 3146 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
commented
Mar 3, 2026
| queryChangefeedPreV22 = "EXPERIMENTAL CHANGEFEED FOR %s WITH updated, cursor = '%s', resolved = '%s';" | ||
| ) | ||
|
|
||
| var retryHistogram = prometheus.NewHistogram(prometheus.HistogramOpts{ |
miparnisari
commented
Mar 3, 2026
| CombinedChangeStreamName = "combined_change_stream" | ||
| ) | ||
|
|
||
| var retryHistogram = prometheus.NewHistogram(prometheus.HistogramOpts{ |
miparnisari
commented
Mar 3, 2026
| Buckets: []float64{1, 2, 3, 5, 10, 25, 100, 250}, | ||
| }) | ||
|
|
||
| var directDispatchQueryHistogram = prometheus.NewHistogram(prometheus.HistogramOpts{ |
Contributor
Author
There was a problem hiding this comment.
FYI not useful, metric can only take 2 values
tstirrat15
force-pushed
the
remove-unwritten-metrics
branch
from
b625384 to
f0ef35b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.