Skip to content

fix(query): fix arrow reversal tagging the subrelation incorrectly#2943

Merged
barakmich merged 1 commit intomainfrom
barakmich/reversal_fix
Mar 3, 2026
Merged

fix(query): fix arrow reversal tagging the subrelation incorrectly#2943
barakmich merged 1 commit intomainfrom
barakmich/reversal_fix

Conversation

@barakmich
Copy link
Contributor

Description

Testing

References

@barakmich barakmich requested a review from a team as a code owner March 3, 2026 17:58
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Mar 3, 2026
tstirrat15
tstirrat15 previously approved these changes Mar 3, 2026
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.52%. Comparing base (8181b86) to head (8fef659).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/query/datastore.go 25.00% 3 Missing ⚠️

❌ Your project status has failed because the head coverage (74.52%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2943      +/-   ##
==========================================
+ Coverage   74.52%   74.52%   +0.01%     
==========================================
  Files         489      489              
  Lines       60356    60361       +5     
==========================================
+ Hits        44973    44979       +6     
+ Misses      12233    12231       -2     
- Partials     3150     3151       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@barakmich barakmich enabled auto-merge (squash) March 3, 2026 19:11
@barakmich barakmich force-pushed the barakmich/reversal_fix branch from 6307dd1 to 8fef659 Compare March 3, 2026 19:22
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barakmich barakmich merged commit 15ae719 into main Mar 3, 2026
73 of 78 checks passed
@barakmich barakmich deleted the barakmich/reversal_fix branch March 3, 2026 20:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) Skip-Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants