Skip to content

chore: use dockerhub instead of gcr#2949

Merged
tstirrat15 merged 1 commit intomainfrom
tstirrat/use-ghcr-for-test-images
Mar 5, 2026
Merged

chore: use dockerhub instead of gcr#2949
tstirrat15 merged 1 commit intomainfrom
tstirrat/use-ghcr-for-test-images

Conversation

@tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Mar 5, 2026

Description

We've been seeing a lot of test flakes from dockertest failing to download images from the google container registry. This changes it to use the normal dockerhub container registry, which we've got creds for already.

Changes

  • Use dockerhub instead of gcr

Testing

Review.

@tstirrat15 tstirrat15 requested a review from a team as a code owner March 5, 2026 15:31
@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Mar 5, 2026
@tstirrat15 tstirrat15 force-pushed the tstirrat/use-ghcr-for-test-images branch from 189d6c5 to 63453b9 Compare March 5, 2026 15:55
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.62%. Comparing base (7cf0595) to head (09a698a).
⚠️ Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (73.62%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2949      +/-   ##
==========================================
- Coverage   74.54%   73.62%   -0.92%     
==========================================
  Files         490      490              
  Lines       60385    60385              
==========================================
- Hits        45008    44450     -558     
- Misses      12227    12778     +551     
- Partials     3150     3157       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tstirrat15 tstirrat15 force-pushed the tstirrat/use-ghcr-for-test-images branch 2 times, most recently from b362239 to c54b471 Compare March 5, 2026 16:03
@github-actions github-actions bot added the area/dependencies Affects dependencies label Mar 5, 2026
@tstirrat15 tstirrat15 force-pushed the tstirrat/use-ghcr-for-test-images branch from c54b471 to 09a698a Compare March 5, 2026 16:07
@tstirrat15 tstirrat15 enabled auto-merge (squash) March 5, 2026 17:53
@tstirrat15 tstirrat15 merged commit 61e1e2f into main Mar 5, 2026
141 of 145 checks passed
@tstirrat15 tstirrat15 deleted the tstirrat/use-ghcr-for-test-images branch March 5, 2026 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2026
@tstirrat15 tstirrat15 changed the title chore: use ghcr instead of gcr chore: use dockerhub instead of gcr Mar 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/datastore Affects the storage system area/dependencies Affects dependencies area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) Skip-Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants