chore: add ctx to RevisionedReader.ReadSchema()#2952
Merged
miparnisari merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (73.65%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2952 +/- ##
===========================================
+ Coverage 48.79% 73.65% +24.87%
===========================================
Files 427 494 +67
Lines 54556 60626 +6070
===========================================
+ Hits 26616 44651 +18035
+ Misses 25225 12869 -12356
- Partials 2715 3106 +391 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d0e4811 to
081aec5
Compare
081aec5 to
dd4347b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Noticed in #2924 that spans were getting disconnected when
experimental-schema-mode=read-new-write-new.After this PR in merged, in https://github.com/josephschorr/spicedb/blob/3272cce5849c019a7df9f5d4241669f9d48df4b5/pkg/datalayer/schema_adapter.go#L340 we must remove the
context.Background().