Skip to content

chore: add ctx to RevisionedReader.ReadSchema()#2952

Merged
miparnisari merged 1 commit intomainfrom
add-ctx-to-ReadSchema
Mar 6, 2026
Merged

chore: add ctx to RevisionedReader.ReadSchema()#2952
miparnisari merged 1 commit intomainfrom
add-ctx-to-ReadSchema

Conversation

@miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Mar 5, 2026

Description

Noticed in #2924 that spans were getting disconnected when experimental-schema-mode=read-new-write-new.

After this PR in merged, in https://github.com/josephschorr/spicedb/blob/3272cce5849c019a7df9f5d4241669f9d48df4b5/pkg/datalayer/schema_adapter.go#L340 we must remove the context.Background().

@github-actions github-actions bot added area/api v1 Affects the v1 API area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) area/dispatch Affects dispatching of requests labels Mar 5, 2026
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.65%. Comparing base (3bbcb02) to head (dd4347b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/services/v1/permissions_queryplan.go 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (73.65%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2952       +/-   ##
===========================================
+ Coverage   48.79%   73.65%   +24.87%     
===========================================
  Files         427      494       +67     
  Lines       54556    60626     +6070     
===========================================
+ Hits        26616    44651    +18035     
+ Misses      25225    12869    -12356     
- Partials     2715     3106      +391     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miparnisari miparnisari marked this pull request as ready for review March 5, 2026 21:22
@miparnisari miparnisari requested a review from a team as a code owner March 5, 2026 21:22
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miparnisari miparnisari force-pushed the add-ctx-to-ReadSchema branch from d0e4811 to 081aec5 Compare March 5, 2026 21:31
@miparnisari miparnisari enabled auto-merge (squash) March 5, 2026 21:31
@miparnisari miparnisari force-pushed the add-ctx-to-ReadSchema branch from 081aec5 to dd4347b Compare March 5, 2026 23:23
@miparnisari miparnisari merged commit 04b003c into main Mar 6, 2026
71 of 78 checks passed
@miparnisari miparnisari deleted the add-ctx-to-ReadSchema branch March 6, 2026 00:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/api v1 Affects the v1 API area/dispatch Affects dispatching of requests area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) Skip-Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants