Skip to content

test(*): remove all t.Parallel() calls in the tests#2955

Open
barakmich wants to merge 2 commits intomainfrom
barakmich/t_parallel
Open

test(*): remove all t.Parallel() calls in the tests#2955
barakmich wants to merge 2 commits intomainfrom
barakmich/t_parallel

Conversation

@barakmich
Copy link
Contributor

Description

Testing

References

@barakmich barakmich requested a review from a team as a code owner March 5, 2026 22:20
@github-actions github-actions bot added area/cli Affects the command line area/schema Affects the Schema Language area/api v1 Affects the v1 API area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) area/dispatch Affects dispatching of requests labels Mar 5, 2026
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.84%. Comparing base (cf317c7) to head (e637f92).

❌ Your project check has failed because the head coverage (73.84%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2955      +/-   ##
==========================================
- Coverage   74.77%   73.84%   -0.93%     
==========================================
  Files         494      494              
  Lines       60623    60623              
==========================================
- Hits        45323    44758     -565     
- Misses      12136    12695     +559     
- Partials     3164     3170       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jzelinskie
Copy link
Member

There have been various PRs over the years adding/removing t.Parallel everywhere.
It'd be great if we could codify it somewhere that you shouldn't add this unless you've really tested it makes things faster. Maybe an approach similar to replacing panic with our linter + MustBugf()?

@tstirrat15 tstirrat15 force-pushed the barakmich/t_parallel branch from 47d3825 to 0f0e12f Compare March 9, 2026 13:27
@tstirrat15 tstirrat15 enabled auto-merge (squash) March 9, 2026 13:44
@tstirrat15 tstirrat15 force-pushed the barakmich/t_parallel branch from 0f0e12f to e637f92 Compare March 9, 2026 13:48
@github-actions github-actions bot added the area/docs Affects docs or metadata (e.g. README) label Mar 9, 2026
@tstirrat15
Copy link
Contributor

I added it as a note in CONTRIBUTING.md. I'm disinclined to enforce anything programmatically because I think it's likely that there are going to be exceptions to our current rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api v1 Affects the v1 API area/cli Affects the command line area/datastore Affects the storage system area/dispatch Affects dispatching of requests area/docs Affects docs or metadata (e.g. README) area/schema Affects the Schema Language area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) Skip-Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants