Skip to content

chore: make development system filesystem-aware#2965

Draft
tstirrat15 wants to merge 2 commits intomainfrom
tstirrat/file-aware-development-system
Draft

chore: make development system filesystem-aware#2965
tstirrat15 wants to merge 2 commits intomainfrom
tstirrat/file-aware-development-system

Conversation

@tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Mar 10, 2026

Description

This PR makes the development package filesystem-aware, which means that it can validate schemas that use import syntax.

It also updates the language server logic to use an overlay filesystem that allows for validation of open files.

TODOs

  • Merge this before merging chore: bring in spicedb and update compilation zed#635
  • Make sure that this works with spicedb-vscode. There may be an issue with spicedb-vscode where it wants to use the WASM package to validate the schema and/or do check watches, rather than the LSP, which probably won't work for composable schemas; if that's the case we need to update spicedb-vscode accordingly. That can happen in subsequent work, since spicedb-vscode doesn't currently work with composable schema stuff.

Changes

TODO

Testing

TODO

@github-actions github-actions bot added the area/schema Affects the Schema Language label Mar 10, 2026
@tstirrat15 tstirrat15 force-pushed the tstirrat/file-aware-development-system branch from cffe476 to e20db9f Compare March 10, 2026 20:38
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 11.33333% with 133 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.84%. Comparing base (0e16dd1) to head (9ef3b65).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/development/schema_position_mapper.go 0.00% 56 Missing ⚠️
pkg/schemadsl/compiler/development.go 0.00% 47 Missing ⚠️
pkg/development/schema.go 33.34% 6 Missing and 2 partials ⚠️
pkg/schemadsl/compiler/positionmapper.go 56.25% 7 Missing ⚠️
pkg/schemadsl/compiler/translator.go 0.00% 7 Missing ⚠️
pkg/schemadsl/compiler/importer.go 0.00% 5 Missing ⚠️
pkg/caveats/parameters.go 0.00% 3 Missing ⚠️

❌ Your project check has failed because the head coverage (48.84%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2965      +/-   ##
==========================================
- Coverage   48.88%   48.84%   -0.03%     
==========================================
  Files         429      430       +1     
  Lines       54628    54678      +50     
==========================================
+ Hits        26700    26704       +4     
- Misses      25220    25257      +37     
- Partials     2708     2717       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miparnisari miparnisari force-pushed the tstirrat/file-aware-development-system branch 2 times, most recently from 3998ee0 to e20db9f Compare March 13, 2026 20:57
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Mar 13, 2026
@miparnisari miparnisari force-pushed the tstirrat/file-aware-development-system branch 3 times, most recently from 9666348 to 2fbc435 Compare March 14, 2026 02:44
…pport for textDocument/definition, and fix mapper
@miparnisari miparnisari force-pushed the tstirrat/file-aware-development-system branch from 2fbc435 to 9ef3b65 Compare March 14, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/schema Affects the Schema Language area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) Skip-Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants