Skip to content

fix: do not register CRDB metrics in init()#2966

Draft
miparnisari wants to merge 1 commit intomainfrom
no-init-to-register-crdb-metrics
Draft

fix: do not register CRDB metrics in init()#2966
miparnisari wants to merge 1 commit intomainfrom
no-init-to-register-crdb-metrics

Conversation

@miparnisari
Copy link
Contributor

Description

Before: if you spun up SpiceDB with a datastore OTHER THAN CRDB, you could see CRDB metrics published.

Now: you don't see them.

Testing

docker-compose up --build and then explore http://localhost:3000/.

@github-actions github-actions bot added the area/datastore Affects the storage system label Mar 10, 2026
@miparnisari miparnisari force-pushed the no-init-to-register-crdb-metrics branch from d4bb2e9 to afd6339 Compare March 10, 2026 23:41
@miparnisari miparnisari changed the title chore: do not register CRDB metrics in init() fix: do not register CRDB metrics in init() Mar 10, 2026
@miparnisari miparnisari force-pushed the no-init-to-register-crdb-metrics branch from afd6339 to 22302d7 Compare March 10, 2026 23:54
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Mar 10, 2026
@miparnisari miparnisari force-pushed the no-init-to-register-crdb-metrics branch from 22302d7 to eedc13b Compare March 11, 2026 00:49
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 72.41379% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.02%. Comparing base (0e16dd1) to head (eedc13b).

Files with missing lines Patch % Lines
...nal/datastore/proxy/schemacaching/watchingcache.go 0.00% 8 Missing ⚠️
internal/datastore/crdb/pool/balancer.go 85.30% 5 Missing ⚠️
internal/datastore/crdb/pool/health.go 75.00% 3 Missing and 1 partial ⚠️
internal/datastore/crdb/pool/pool.go 73.34% 3 Missing and 1 partial ⚠️
internal/datastore/crdb/crdb.go 78.58% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2966      +/-   ##
==========================================
- Coverage   48.88%   46.02%   -2.86%     
==========================================
  Files         429      429              
  Lines       54628    54687      +59     
==========================================
- Hits        26700    25163    -1537     
- Misses      25220    26881    +1661     
+ Partials     2708     2643      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant