fix: do not register CRDB metrics in init()#2966
Draft
miparnisari wants to merge 1 commit intomainfrom
Draft
Conversation
d4bb2e9 to
afd6339
Compare
afd6339 to
22302d7
Compare
22302d7 to
eedc13b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2966 +/- ##
==========================================
- Coverage 48.88% 46.02% -2.86%
==========================================
Files 429 429
Lines 54628 54687 +59
==========================================
- Hits 26700 25163 -1537
- Misses 25220 26881 +1661
+ Partials 2708 2643 -65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before: if you spun up SpiceDB with a datastore OTHER THAN CRDB, you could see CRDB metrics published.
Now: you don't see them.
Testing
docker-compose up --buildand then explore http://localhost:3000/.