Skip to content

feat(qp): prune branches that cannot lead to the subject type of the …#2968

Draft
miparnisari wants to merge 1 commit intomainfrom
qp-subject-type-shear
Draft

feat(qp): prune branches that cannot lead to the subject type of the …#2968
miparnisari wants to merge 1 commit intomainfrom
qp-subject-type-shear

Conversation

@miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Mar 11, 2026

…request

Description

This is an optimization for Check API when using the query planner. We prune branches of the tree that can never lead to the subject type in the request.

Testing

Unit tests

References

@github-actions github-actions bot added area/api v1 Affects the v1 API area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Mar 11, 2026
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 70.21277% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.83%. Comparing base (0e16dd1) to head (9779e99).

Files with missing lines Patch % Lines
pkg/query/optimize_reachability.go 73.34% 16 Missing and 8 partials ⚠️
internal/services/v1/permissions_queryplan.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2968       +/-   ##
===========================================
+ Coverage   48.88%   74.83%   +25.96%     
===========================================
  Files         429      497       +68     
  Lines       54628    60789     +6161     
===========================================
+ Hits        26700    45486    +18786     
+ Misses      25220    12140    -13080     
- Partials     2708     3163      +455     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miparnisari miparnisari marked this pull request as ready for review March 11, 2026 16:59
@miparnisari miparnisari requested a review from a team as a code owner March 11, 2026 16:59
@miparnisari miparnisari marked this pull request as draft March 12, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api v1 Affects the v1 API area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant