Skip to content

refactor: create new queryopt package to target query plan optimizations #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barakmich wants to merge 3 commits into
base: main
Choose a base branch
from

refactor: move optimize into the new package, and change callsites

90a93cb
Select commit
Loading
Failed to load commit list.
Open

refactor: create new queryopt package to target query plan optimizations #2970

refactor: move optimize into the new package, and change callsites
90a93cb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 12, 2026 in 0s

74.64% of diff hit (target 48.86%)

View this Pull Request on Codecov

74.64% of diff hit (target 48.86%)

Annotations

Check warning on line 56 in internal/services/v1/permissions_queryplan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/services/v1/permissions_queryplan.go#L56 

Added line #L56 was not covered by tests

Check warning on line 64 in internal/services/v1/permissions_queryplan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/services/v1/permissions_queryplan.go#L61-L64 

Added lines #L61 - L64 were not covered by tests

Check warning on line 66 in internal/services/v1/permissions_queryplan.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/services/v1/permissions_queryplan.go#L66 

Added line #L66 was not covered by tests

Check warning on line 89 in pkg/query/advisor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/advisor.go#L88-L89 

Added lines #L88 - L89 were not covered by tests

Check warning on line 298 in pkg/query/canonicalize.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/canonicalize.go#L295-L298 

Added lines #L295 - L298 were not covered by tests

Check warning on line 51 in pkg/query/queryopt/caveat_pushdown.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/queryopt/caveat_pushdown.go#L50-L51 

Added lines #L50 - L51 were not covered by tests

Check warning on line 15 in pkg/query/queryopt/registry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/queryopt/registry.go#L15 

Added line #L15 was not covered by tests

Check warning on line 24 in pkg/query/queryopt/registry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/queryopt/registry.go#L23-L24 

Added lines #L23 - L24 were not covered by tests

Check warning on line 50 in pkg/query/queryopt/registry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/queryopt/registry.go#L50 

Added line #L50 was not covered by tests

Check warning on line 56 in pkg/query/queryopt/registry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/queryopt/registry.go#L55-L56 

Added lines #L55 - L56 were not covered by tests

Check warning on line 63 in pkg/query/queryopt/registry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/queryopt/registry.go#L62-L63 

Added lines #L62 - L63 were not covered by tests

Check warning on line 69 in pkg/query/queryopt/registry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/queryopt/registry.go#L69 

Added line #L69 was not covered by tests

Check warning on line 75 in pkg/query/queryopt/registry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/queryopt/registry.go#L73-L75 

Added lines #L73 - L75 were not covered by tests

Check warning on line 79 in pkg/query/queryopt/registry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/queryopt/registry.go#L79 

Added line #L79 was not covered by tests

Check warning on line 81 in pkg/query/queryopt/registry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/queryopt/registry.go#L81 

Added line #L81 was not covered by tests
View more details on Codecov