Fix text content in inline embedded nodes#57
Open
jmoggr wants to merge 3 commits intoautomerge:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I leaned heavily on LLMs for this. I'm confident in my understanding of the problem, but I am not confident in understanding my proposed fix in the context of the whole project.
Replaying
automergespans produced incorrectprosemirrordocuments when inline embedded nodes contain text. Text content inside the node would move outside the inline embedded node as a sibling after a save/load cycle. IntraverseSpans, thenewBlockmethod treats all embed blocks as leaf nodes so subsequent text spans are then added to the parent container instead of the embed.This is fixed by checking if the node is lineline and can contain text then the nodes is pushed so that subsequent text becomes children.
This is "stacked" on top of #56 and #55