Skip to content

Comments

re-use prosemirror basic schema and fix addIsAmgBlockAttr#7

Open
BrianHung wants to merge 1 commit intoautomerge:mainfrom
BrianHung:main
Open

re-use prosemirror basic schema and fix addIsAmgBlockAttr#7
BrianHung wants to merge 1 commit intoautomerge:mainfrom
BrianHung:main

Conversation

@BrianHung
Copy link
Contributor

Two things

  • refactors schema.ts to re-use prosemirror-schema-basic and prosemirror-schema-list for the base schema
  • changes addIsAmgBlockAttr to create a new copy instead of modifying map; this is important when re-using an existing Schema such as when letting users bring their own generic Schema

@alexjg
Copy link
Collaborator

alexjg commented May 15, 2024

Thanks for the PR! I actually have a lot of changes in flight on this particular part of the codebase right now as I do the work to enable user provided schemas. Is this blocking you or do you mind waiting a few days whilst I whip that into shape?

@BrianHung
Copy link
Contributor Author

Not blocking me! Just playing around with automerge-prosemirror. I do have a custom schema that I want to bring & want to try to integrate a cloudflare KV store persistence for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants