This repository was archived by the owner on Oct 17, 2025. It is now read-only.
Improve change highlighting in 05-react#133
Open
KieranHunt wants to merge 1 commit intoautomerge:mainfrom
Open
Improve change highlighting in 05-react#133KieranHunt wants to merge 1 commit intoautomerge:mainfrom
KieranHunt wants to merge 1 commit intoautomerge:mainfrom
Conversation
✅ Deploy Preview for automerge-github-io-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
The relevant bit from the Netlify deploy: https://deploy-preview-133--automerge-github-io-previews.netlify.app/docs/tutorial/react/#editing-a-document |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Creating a new Item" in the React Integration step of the tutorial (https://automerge.org/docs/tutorial/react/#creating-a-new-item) highlights adding a
onClickhandler as follows:However, this is the first time that the
onClickhandler is being added.I believe that the highlight should include adding the onClick property rather than just defining its body.
This is consistent with the "Updating the done state" https://automerge.org/docs/tutorial/react/#updating-the-done-state a few lines below.