Skip to content

added feature to choose classifiers allowed#32

Open
lucasjuliano wants to merge 3 commits intoautoml:masterfrom
lucasjuliano:master
Open

added feature to choose classifiers allowed#32
lucasjuliano wants to merge 3 commits intoautoml:masterfrom
lucasjuliano:master

Conversation

@lucasjuliano
Copy link

No description provided.

@larskotthoff
Copy link
Collaborator

Thanks. Could you please rename the method allowedClassifiersToString? The name is misleading because that's not what it does.

I'm getting an error message that's not informative when I run it with no classifiers in the list. I'm getting the same thing when adding a classifier that isn't defined in Auto-WEKA (e.g. bayes A1DE). Could you provide a better error message and filter the classifiers you can't select please?

Is there any way to hide the list of parameters for the classifiers when you choose them?

Could you change the default classifier back to RandomForest please? And I can currently add duplicates to the list of allowed classifiers.

It would also be great if you could update the screenshots in the documentation and write a short paragraph on the feature you've implemented.

Finally, don't forget to add yourself to the list of authors in Description.props!

@lucasjuliano
Copy link
Author

@larskotthoff As the interface used to select the classifiers was ready built in Autoweka, it would be hard to take off the options of the parameters of the classifiers, so I just wrote the initial way you told me that would be just using text.
Now, it checks if the classifier written is a valid option.
I also changed the deafult classifier back to RandomForest.

@larskotthoff
Copy link
Collaborator

Thanks, but this breaks the selection of allowed classifiers -- I no longer get a menu that I can choose from. Changing the default should be only a matter of reordering the classifiers in the list of allowed classifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants